Opened 12 years ago

Closed 12 years ago

#4546 closed defect (fixed)

disabled buttons in the toolbar should not receive focus but disabled menu items should

Reported by: simonjb Owned by: simonjb
Priority: high Milestone: 1.0
Component: Accessibility Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by simonjb)

Potential implementation:

  • add a method to _Widget: isFocusable()
  • generally returns true, but for buttons returns !this.disabled
  • modify _KeyNavContainer to test widget.isFocusable() when navigating amongst widgets

Another option:

  • add a property to _KeyNavContainer: focusDisabled
  • modify _KeyNavContainer to check this value when navigating amongst widgets
  • Toolbar would set focusDisabled to false
  • Menu would set focusDisabled to true

Attachments (1)

isFocusable.diff (1.5 KB) - added by simonjb 12 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 12 years ago by simonjb

Milestone: 1.0

comment:2 Changed 12 years ago by simonjb

Description: modified (diff)

comment:3 Changed 12 years ago by simonjb

Status: newassigned

Changed 12 years ago by simonjb

Attachment: isFocusable.diff added

comment:4 Changed 12 years ago by simonjb

Resolution: fixed
Status: assignedclosed

(In [10731]) Added an isFocusable() method to _Widget and overrode it in _FormWidget with logic for checking disabled state. Fixes #4546: disabled buttons in the toolbar should not receive focus but disabled menu items should.

Note: See TracTickets for help on using tickets.