Opened 12 years ago

Closed 12 years ago

#4508 closed defect (fixed)

Stack, TabContainer: key navigation is backwards in RTL

Reported by: Adam Peller Owned by: davidb
Priority: high Milestone: 1.1
Component: Dijit Version: 0.9
Keywords: bidi Cc: hwcdl@…, simonjb, Becky Gibson
Blocked By: Blocking:

Description

perhaps others. We need to special case anywhere we use a left or right arrow, unfortunately, or just use something neutral, where possible. We should probably do a quick search through the widgets.

Change History (8)

comment:1 Changed 12 years ago by davidb

This is making a stronger case for implementing tabcontainer using KeyNavContainer?, where Bidi is solved. Better to fix in one place right?

Thoughts?

comment:2 Changed 12 years ago by bill

Makes sense, althogh maybe it's StackController? that should extend KeyNavContainer?, rather than StackContainer?? Not sure.

comment:3 Changed 12 years ago by davidb

Status: new → assigned

comment:4 Changed 12 years ago by davidb

(In [11846]) Refs #4508: fixes keyboard navigation in RTL

comment:5 Changed 12 years ago by davidb

We need to look at the forward/back (_adjacent) api in StackContainer? to make sure we are doing the right thing there too.

comment:6 Changed 12 years ago by Adam Peller

Resolution: → fixed
Status: assigned → closed

(In [12274]) redo [11846]. Fixes #4508 !strict

comment:7 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: closed → reopened

added an example to test_TabContainer.html with vertical tabs. The key navigation is backwards in rtl.

comment:8 Changed 12 years ago by Adam Peller

Resolution: → fixed
Status: reopened → closed

(In [12796]) Fix RTL key nav for vertical tabs. Fixes #4508 !strict

Note: See TracTickets for help on using tickets.