Opened 12 years ago

Closed 11 years ago

#4502 closed defect (worksforme)

TabContainer: Several bugs when adding tabs programatically

Reported by: guest Owned by: Adam Peller
Priority: high Milestone: 1.3
Component: Dijit Version: 0.9
Keywords: Cc: tk
Blocked By: Blocking:

Description (last modified by Adam Peller)

I noticed the problems in test_TabContainer_remote.html .

  • When adding a tab , and selecting different tabs , the css styles won't always change as they should to selected , not selected .
  • When adding more than one tab , the new tabs will have 1px cutoff in between the button and the tab area
  • When adding more tabs , so that a second line of tabs i required , the first tab showing up on the second line , doesn't create a second line , it just overlaps the content . The same tab also doesn't show up at the start of the first line , instead shows up somewhere in the middle
  • When adding even more tabs , the second line gets created but tabs are still starting from the middle

Attachments (1)

tabtest1.html (1.3 KB) - added by guest 12 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 12 years ago by Adam Peller

Component: GeneralDijit
Owner: anonymous deleted

comment:2 Changed 12 years ago by Adam Peller

Owner: set to Adam Peller

comment:3 Changed 12 years ago by tk

Cc: tk added

Testing this, it appears to be a race condition for layout() calling TC.layout() after wrapping the first tab.... fixes the 2nd row immediately.... Alignment... I dont have a good CSS tool to play with here (just FirebugLite?)

comment:4 Changed 12 years ago by Adam Peller

Milestone: 1.1

Changed 12 years ago by guest

Attachment: tabtest1.html added

comment:5 Changed 12 years ago by guest

I noticed another drawing bug when programatically adding tabs to an empty tab container. See attached tabtest1.html for example. It looks slightly different in firefox 2.0 (windows) and IE6, but neither draw it correctly.

comment:6 Changed 11 years ago by bill

Summary: Several bugs when adding tabs programatically to a tab containerTabContainer: Several bugs when adding tabs programatically

comment:7 Changed 11 years ago by Adam Peller

Milestone: 1.11.2

will attempt rewrite of TabContainer? layout in 1.2. look at this then.

comment:8 Changed 11 years ago by Adam Peller

Description: modified (diff)

tk, can you reproduce the original problem? Multiple tab rows appear to wrap properly in trunk. I can only see the error in the test case included here.

comment:9 Changed 11 years ago by Adam Peller

Milestone: 1.21.3

comment:10 Changed 11 years ago by bill

(In [15137]) Fixes #5821, fixes #7594: programatically adding tab to empty TabContainer? fails. Problem was that we were querying size of tab strip before any tabs had been created, thus it was coming out as 0.

May also help fix part of #4502 (refs #4502).

!strict

comment:11 Changed 11 years ago by Adam Peller

the only problem I can see remaining is a missing pixel on the current test. Is there anything else? I'd be inclined to file that as a new, low-priority ticket.

comment:12 Changed 11 years ago by Adam Peller

Resolution: worksforme
Status: newclosed
Note: See TracTickets for help on using tickets.