Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4496 closed defect (fixed)

Avoid allowing fractional calculations when sizing domNodes

Reported by: dante Owned by: dante
Priority: high Milestone: 1.0
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by dante)

apparently it goes against css spec and allegedly is what causes the border to be missing in rare occasion. reported via http://dojotoolkit.org/forum/dijit-dijit-0-9/dijit-development-discussion/dijit-dialog-bug-half-pixels

Math.floor() any t/l/w/h attributes you set involving division :)

Attachments (1)

dialog.patch​ (567 bytes) - added by dante 12 years ago.
a fix.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by dante

Attachment: dialog.patch​ added

a fix.

comment:1 Changed 12 years ago by dante

Description: modified (diff)
Owner: changed from bill to dante
Status: new → assigned
Summary: Dialog can calculate fractional top and left → Avoid allowing fractional calculations when sizing domNodes

comment:2 Changed 12 years ago by dante

Resolution: → fixed
Status: assigned → closed

(In [10548]) fixes #4496 - scanned over other dijit's and didn't see any similar sizing techniques. will look over dojox, but it seems like this should be practiced anyway, esp if it violates specs?

comment:3 Changed 12 years ago by dante

(In [10551]) refs #4496 - sorry! cannot believe this didn't alert me, maybe cache? ugh.

Note: See TracTickets for help on using tickets.