Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#4487 closed task (fixed)

DropDownTextBox unneeded

Reported by: bill Owned by: bil
Priority: high Milestone: 1.0
Component: Dijit - Form Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

DropDownTextBox? is only used by ComboBox?, and much of the code in it is Combobox specific (like the part about sizing the drop down list to take the maximum amount of space available on the screen). So should merge code into Combobox.js.

Change History (2)

comment:1 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

(In [10544]) Fold DropDownTextBox? mixin into ComboBox?. Having a separate DropDownTextBoxmixin? was unnecessary, and surprisingly cost about 100 lines of code. Also removed onkeypresshandler from ComboBoxMenu?, which seemed to be inert code, since focus is always on the ComboBox? itself.

Fixes #4487

comment:2 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.