Opened 15 years ago
Closed 15 years ago
#4463 closed defect (fixed)
Regression in [10478]: test_FilteringSelect generates error
Reported by: | haysmark | Owned by: | James Burke |
---|---|---|---|
Priority: | high | Milestone: | 1.0 |
Component: | Core | Version: | 0.9 |
Keywords: | 4dijit | Cc: | |
Blocked By: | Blocking: |
Description (last modified by )
Load this in Firefox:
http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/form/test_FilteringSelect.html
I get this in Firebug:
dojo.data.ItemFileReadStore is not a constructor [Break on this error] myStore2 = new dojo.data.ItemFileReadStore({url: 'comboBoxDataToo.json'});
Which is strange because the line right before it also declares an ItemFileReadStore? and it works fine. This starts happening in [10478]. This did not happen in [10477].
Change History (5)
comment:1 Changed 15 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 15 years ago by
comment:3 Changed 15 years ago by
Thanks. Actually those data stores should be declared in markup like
<div dojoType="dojo.data.ItemFileReadStore" jsId="myStore" url="comboBoxData"></div> <div dojoType="dojo.data.ItemFileReadStore" jsId="myStoreToo" url="comboBoxData"></div>
... just because that's the standard way we are doing stuff in dijit nowadays. I'll update that.
comment:5 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
This is caused because this test page has debugAtAllCosts set to true in the page, however it tries to do these two lines outside of a dojo.addOnLoad() block:
I can see where they cannot be done in an addOnLoad callback, since that callback will not be called after widget parsing, and there are some widgets declared in markup that use those stores. So my fix is going to be to remove debugAtAllCosts for now. If you want to use debugAtAllCosts in the page, turn off parseOnLoad, put the myStore lines in a dojo.addOnLoad() call, then after that, parse the page for widgets.