Opened 12 years ago

Closed 12 years ago

#4455 closed defect (fixed)

Build fails if a dojo.requireIf dependency's test expression fails

Reported by: James Burke Owned by: James Burke
Priority: high Milestone: 1.0
Component: BuildSystem Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

If you include a module resource, like dojo.gfx, that has some dojo.requireIf() calls in them, and the expression in that requireIf throws an error, it stops the build. It should not do that since the expression could be something that is only valid at runtime in a browser. An example from dojox.gfx:

dojo.requireIf(dojox.gfx.renderer == "svg", "dojox.gfx.svg");

In the context of the build, dojox has not been defined (and dojox.gfx.renderer has not been calculated yet).

Fix it so that the build does not fail in those cases, but just skips adding that resource to the layer file.

Change History (1)

comment:1 Changed 12 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [10500]) Fixes #4455. Some valid requireIfs cause the build to fail since the objects in the test expression may not exist when rhino is run.

Note: See TracTickets for help on using tickets.