Opened 12 years ago

Closed 12 years ago

Last modified 7 years ago

#4441 closed defect (fixed)

Add DnD Features to dijit.tree

Reported by: Dustin Machi Owned by: Dustin Machi
Priority: high Milestone: 1.1
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Implement DnD features for dijit.Tree. Default behavior is still a little questionable to me, it seems like most uses of the tree need to define custom behavior in and aroudn the data (which is dojo.data).

Some features that have to be there:

  • selection, multiple section of tree nodes (not range selection for this version)
  • Drop Items on to tree
  • customized methods for verifying the acceptance of drop by the tree or a node
  • customized item creation and drop methods

Some features that wont' be there for now:

  • node ordering within the tree itself

Change History (18)

comment:1 Changed 12 years ago by Dustin Machi

(In [10486]) initial, mostly working for dropping, version of dnd tree. Verified existing behavior of the tree has not been affected. One new feature added to the tree itself and that is to have multiple children attributes to pull child item/nodes from. more to come soon. refs #4441

comment:2 Changed 12 years ago by Dustin Machi

(In [10488]) more work on dnd for dijit.tree. refs #4441

comment:3 Changed 12 years ago by Adam Peller

Can we close this for 1.0?

comment:4 Changed 12 years ago by Adam Peller

Owner: changed from Dustin Machi to eugene

dmachi needs eugene to review and make sure this fits with his dnd work

comment:5 Changed 12 years ago by Adam Peller

Owner: changed from eugene to Eugene Lazutkin

comment:6 Changed 12 years ago by Eugene Lazutkin

Owner: changed from Eugene Lazutkin to Adam Peller

The code for the tree DnD looks fine to me. The test file test_Tree_DnD.html doesn't work properly because some function is undefined, and dojo.data fails time to time.

comment:7 Changed 12 years ago by Adam Peller

Owner: changed from Adam Peller to Dustin Machi

comment:8 Changed 12 years ago by Dustin Machi

Resolution: fixed
Status: newclosed

(In [11322]) fix dnd for dropping items on the tree and its test file. fixes #4441

comment:9 in reply to:  8 Changed 12 years ago by guest

Resolution: fixed
Status: closedreopened

Replying to dmachi:

(In [11322]) fix dnd for dropping items on the tree and its test file. fixes #4441

Some bugs remaining on test file test_Tree_DnD.html dor dojo 1.0.0rc1

IE 7 1) When you drop an element in the collection tree, you get an undefined element (even when it is acceptable) 2) When you drag an element from the right part of the drag handle (not on the text), you are making a selection and everything becomes black as you drag

Firefox 2.0 1) If you drag an element from the right part of the drag handle (not on the text but next to it), you get an error when you drop it on the tree (this.avatar has no properties)

comment:10 Changed 12 years ago by Adam Peller

Milestone: 1.01.0.1

comment:11 Changed 12 years ago by Adam Peller

Milestone: 1.0.11.0.2

comment:12 Changed 12 years ago by Adam Peller

Priority: normalhigh
severity: normalmajor

among other things, there's some really odd behavior where the avatar does not go away after you drop

comment:13 Changed 12 years ago by Adam Peller

also, click on "Collections" and you'll get an exception in getIdentity() (in FF) It's called with a null arg.

comment:14 Changed 12 years ago by Adam Peller

Milestone: 1.0.21.0.3

comment:15 Changed 12 years ago by Dustin Machi

Resolution: wontfix
Status: reopenedclosed

Further modifications and work by bill have obsoleted this ticket

comment:16 Changed 12 years ago by bill

Milestone: 1.0.31.1
Resolution: wontfix
Status: closedreopened

I'm going to mark this as fixed because I believe. Tree DND is working now in all cases. (In 1.1, not 1.0.3)

comment:17 Changed 12 years ago by bill

Resolution: fixed
Status: reopenedclosed

comment:18 Changed 7 years ago by bill

In [29938]:

Rearrange the test page so there's no scrolling during the automated test, which adds a lot of items to the Tree, making it very tall. Refs #4441.

Note: See TracTickets for help on using tickets.