Opened 12 years ago

Closed 12 years ago

#4424 closed defect (fixed)

dojo.isObject: why true for null?

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone: 1.0
Component: Core Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Maybe this is intentional, but I just tripped over it and there's a FIXME in the file.

Change History (5)

comment:1 Changed 12 years ago by Adam Peller

(In [10470]) missing null check. refs #4424, #3085

comment:2 Changed 12 years ago by alex

hrm... typeof null == "object", and isObject should probably reflect that. This is a JavaScript?-ism and i'm not sure we should fix it since we rely on it in the widget system.

comment:3 Changed 12 years ago by Adam Peller

Owner: changed from alex to Adam Peller
Status: new → assigned

Cool. Then the fix is to remove the FIXME and document it.

comment:4 Changed 12 years ago by Adam Peller

ok, forgive the ignorance, but why then is an extra it === null check required?

comment:5 Changed 12 years ago by Adam Peller

Resolution: → fixed
Status: assigned → closed

(In [10475]) Add comments for isObject plus style mods. Fixes #4424, #3961

Note: See TracTickets for help on using tickets.