Opened 14 years ago
Closed 14 years ago
#4424 closed defect (fixed)
dojo.isObject: why true for null?
Reported by: | Adam Peller | Owned by: | Adam Peller |
---|---|---|---|
Priority: | high | Milestone: | 1.0 |
Component: | Core | Version: | 0.9 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Maybe this is intentional, but I just tripped over it and there's a FIXME in the file.
Change History (5)
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
hrm... typeof null == "object", and isObject should probably reflect that. This is a JavaScript?-ism and i'm not sure we should fix it since we rely on it in the widget system.
comment:3 Changed 14 years ago by
Owner: | changed from alex to Adam Peller |
---|---|
Status: | new → assigned |
Cool. Then the fix is to remove the FIXME and document it.
comment:4 Changed 14 years ago by
ok, forgive the ignorance, but why then is an extra it === null check required?
comment:5 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
(In [10470]) missing null check. refs #4424, #3085