Opened 13 years ago
Closed 12 years ago
#4421 closed defect (wontfix)
[cla][patch] Safari and dijit.Editor
Reported by: | guest | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | high | Milestone: | 1.2 |
Component: | Editor | Version: | 0.9 |
Keywords: | Cc: | [email protected]… | |
Blocked By: | Blocking: |
Description (last modified by )
Hi there!
I posted some Patches back in 2006 to get Editor2 working with Safari - and now I'm at it again for dijit.Editor :)
So far, I've managed to get Font-Formatting and Alignment working, mainly by preventing Safari from losing the selection on click.
I've also implemented a Html-Source editing plugin, which I'm happy to share if you're interested. For that I needed to fix RichText#replaceValue?() - is there any particular reason why there is no catch-all that just hands the call off to setValue?
Finally I had an issue where Safari would only display the text-value, with all html-formatting stripped.
I'm attaching a patch with these three changes.
thanks for any feedback you can give me
cheers, Hannes
Attachments (1)
Change History (8)
Changed 13 years ago by
Attachment: | dojo.editor.patch added |
---|
comment:1 Changed 13 years ago by
Milestone: | → 1.0 |
---|---|
Owner: | changed from anonymous to alex |
Summary: | Safari and dijit.Editor → [cla][patch] Safari and dijit.Editor |
comment:2 Changed 13 years ago by
Hannes, sorry this has gotten stale again. Are these patches still required for Safari 3? We've since dropped support for Safari 2.
comment:4 Changed 13 years ago by
Component: | General → Editor |
---|---|
Description: | modified (diff) |
still don't know if any of this is needed in the Safari 3+ world. Without a confirmation we should probably close as wontfix.
comment:5 Changed 12 years ago by
Owner: | changed from alex to Douglas Hays |
---|
Some of this patch appears to already be in trunk. Doug can you look at some of the remaining parts like the mousedown event handler? Clearly, if it's specific to 2.0.4, we should wontfix.
comment:6 Changed 12 years ago by
Type: | enhancement → defect |
---|
comment:7 Changed 12 years ago by
Resolution: | → wontfix |
---|---|
Status: | new → closed |
I tested with Safari 3.1.2 on WinXP and these problems appear to be fixed.
cla confirmed, alex, please take a look at the patch.