Opened 12 years ago

Closed 7 years ago

#4408 closed enhancement (wontfix)

[patch] [CLA] Form widget: process native elements in addition to widgets

Reported by: guest Owned by: wolfram
Priority: high Milestone: future
Component: Dijit Version: 0.9
Keywords: Cc: gizmojo.org, wolfram.kriesing@…, dante, alex
Blocked By: Blocking:

Description

dijit.form.Form.getValues() currently ONLY submits values of widgets inside the form not values of normal form elements, this patch fixes that.

Attachments (1)

form-getValues-fix.diff​ (1.0 KB) - added by guest 12 years ago.
temporary simple fix, to make it at least work

Download all attachments as: .zip

Change History (16)

Changed 12 years ago by guest

Attachment: form-getValues-fix.diff​ added

temporary simple fix, to make it at least work

comment:1 Changed 12 years ago by guest

for the record I proposed the patch wolfram.kriesing@…, guest might not have a CLA :-)

comment:2 Changed 12 years ago by bill

Component: General → Dijit
Milestone: → 1.1
Owner: anonymous deleted
Summary: dijit.form.Form.getValues() temporary fix → [patch] [CLA] dijit.form.Form.getValues() temporary fix

comment:3 Changed 12 years ago by guest

Set to milestone 1.1? Why that? If the form elements that are no widgets dont get returned by getValues() the widget will be unusable for those forms not using widgets for all the form elements, as for me for example. In 0.4 that was very well possible. Is my provided quick-fix breaking something that it could not be applied before 1.1?

comment:4 Changed 12 years ago by bill

Summary: [patch] [CLA] dijit.form.Form.getValues() temporary fix → [patch] [CLA] Form widget: process native elements in addition to widgets
Type: defect → enhancement

Patch looks good but also, the set function needs to handle native elements (in addition to the get function), and test file needs to be updated to check that.

Thanks!

comment:5 Changed 12 years ago by gizmojo.org

Cc: gizmojo.org added

comment:6 Changed 12 years ago by bill

Owner: set to wolfram

Hi Wolfram,

Can you update this patch so that:

  • checkboxes and radio buttons work
  • update test_Form.html to have native elements in addition to widgets
  • make setValues() work too

Otherwise we have to say that Form sort-of works for native elements, which I guess is better than nothing, but not ideal.

Thanks!

comment:7 Changed 12 years ago by dylan

Cc: wolfram.kriesing@… added

Wolfram, please see bill's previous comments... I think getting this fixed for Dojo 1.1 is important.

comment:8 Changed 12 years ago by wolfram

i will try to get it done for the 1.1beta

comment:9 Changed 12 years ago by dante

(In [12012]) refs #4408, #5359, #5550 - adds semantic degradable textarea, select, and hidden input types that work with dijit.form.Form

comment:10 Changed 12 years ago by Adam Peller

Milestone: 1.1 → 1.2

comment:11 Changed 11 years ago by dylan

Cc: dante added

Wolfram, Pete, what's the status of this one?

comment:12 Changed 11 years ago by bill

Milestone: 1.2 → future

defer dormant enhancements to "future" (they don't look like they're getting fixed soon so might as well mark as such)

comment:13 Changed 11 years ago by alex

Cc: alex added

comment:14 Changed 11 years ago by Eugene Lazutkin

This ticket intersects 100% with #7999 (the form manager in DojoX).

comment:15 Changed 7 years ago by bill

Resolution: → wontfix
Status: new → closed

Looks like this won't be fixed.

Note: See TracTickets for help on using tickets.