Opened 14 years ago
Closed 9 years ago
#4408 closed enhancement (wontfix)
[patch] [CLA] Form widget: process native elements in addition to widgets
Reported by: | guest | Owned by: | wolfram |
---|---|---|---|
Priority: | high | Milestone: | future |
Component: | Dijit | Version: | 0.9 |
Keywords: | Cc: | gizmojo.org, [email protected]…, dante, alex | |
Blocked By: | Blocking: |
Description
dijit.form.Form.getValues() currently ONLY submits values of widgets inside the form not values of normal form elements, this patch fixes that.
Attachments (1)
Change History (16)
Changed 14 years ago by
Attachment: | form-getValues-fix.diff added |
---|
comment:1 Changed 14 years ago by
for the record I proposed the patch [email protected]…, guest might not have a CLA :-)
comment:2 Changed 14 years ago by
Component: | General → Dijit |
---|---|
Milestone: | → 1.1 |
Owner: | anonymous deleted |
Summary: | dijit.form.Form.getValues() temporary fix → [patch] [CLA] dijit.form.Form.getValues() temporary fix |
comment:3 Changed 14 years ago by
Set to milestone 1.1? Why that? If the form elements that are no widgets dont get returned by getValues() the widget will be unusable for those forms not using widgets for all the form elements, as for me for example. In 0.4 that was very well possible. Is my provided quick-fix breaking something that it could not be applied before 1.1?
comment:4 Changed 14 years ago by
Summary: | [patch] [CLA] dijit.form.Form.getValues() temporary fix → [patch] [CLA] Form widget: process native elements in addition to widgets |
---|---|
Type: | defect → enhancement |
Patch looks good but also, the set function needs to handle native elements (in addition to the get function), and test file needs to be updated to check that.
Thanks!
comment:5 Changed 14 years ago by
Cc: | gizmojo.org added |
---|
comment:6 Changed 14 years ago by
Owner: | set to wolfram |
---|
Hi Wolfram,
Can you update this patch so that:
- checkboxes and radio buttons work
- update test_Form.html to have native elements in addition to widgets
- make setValues() work too
Otherwise we have to say that Form sort-of works for native elements, which I guess is better than nothing, but not ideal.
Thanks!
comment:7 Changed 13 years ago by
Cc: | [email protected]… added |
---|
Wolfram, please see bill's previous comments... I think getting this fixed for Dojo 1.1 is important.
comment:9 Changed 13 years ago by
comment:10 Changed 13 years ago by
Milestone: | 1.1 → 1.2 |
---|
comment:12 Changed 13 years ago by
Milestone: | 1.2 → future |
---|
defer dormant enhancements to "future" (they don't look like they're getting fixed soon so might as well mark as such)
comment:13 Changed 13 years ago by
Cc: | alex added |
---|
comment:14 Changed 12 years ago by
This ticket intersects 100% with #7999 (the form manager in DojoX).
comment:15 Changed 9 years ago by
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Looks like this won't be fixed.
temporary simple fix, to make it at least work