Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#4391 closed defect (fixed)

Bottom of button cut off with IE (7?) and soria theme

Reported by: guest Owned by: Sam Foster
Priority: high Milestone: 1.0
Component: Dijit - Form Version: 0.9
Keywords: button theme soria Cc:
Blocked By: Blocking:

Description

The bottom border of the button in the following example does not appear in IE7. It displays well in Firefox. If the theme is changed to tundra, it displays fine in both. The font size doesn't seem to matter, but the font does. I would attach a screen shot if that was possible.

<html>

<head>

<script type="text/javascript" src="../dojoAjax/dojo/dojo.js"

djConfig="parseOnLoad:true">

</script> <script type="text/javascript" >

dojo.require("dojo.parser");

dojo.require("dijit.form.Button");

</script>

<style type="text/css"> @import "../dojoAjax/dijit/themes/soria/soria.css";

body {

font-family: Arial;

}

</style>

</head> <body class="soria">

<div dojoType="dijit.form.Button">Hi</div>

</body>

</html>

Attachments (2)

Button.jpg (12.0 KB) - added by guest 12 years ago.
Button missing border
buttons_4391_sfoster_20071018.patch (2.9 KB) - added by Sam Foster 12 years ago.

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by guest

Attachment: Button.jpg added

Button missing border

comment:1 Changed 12 years ago by guest

Oh, it is possible to add an attachment, so there you go.

comment:2 Changed 12 years ago by bill

Component: LookAndFeelDijit
Milestone: 1.0
Owner: changed from dylan to dante

Sfoster fixed this same problem for tundra; I guess it didn't get copied over to soria? Some hack like adding zoom:1 (check the SVN log to find it).

comment:3 Changed 12 years ago by dante

Status: newassigned

comment:4 Changed 12 years ago by Sam Foster

Owner: changed from dante to Sam Foster
Status: assignednew

buttons_4391_sfoster_20071018.patch adds a line to dijit.css to normalize line-height for the buttons. This accounts for some of the "works in the themeTester but not in the test page" issues people have reported.

the fix to tundra and soria is to style the inner contents of the button to have the inline-block behavior. This lets us set top/bottom padding and more reliably control overall button height. Tweaks follow for the outer buttonNode to get it back to where it was visually.

Changed 12 years ago by Sam Foster

comment:5 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

(In [10927]) Fixes #4391: Bottom of button cut off with IE (7?) and soria theme. Again, fixes issues with setting height on display:inline nodes that needed to be inline-block. Patch from Sam Foster (thanks Sam!). CLA on file.

comment:6 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.