#4391 closed defect (fixed)
Bottom of button cut off with IE (7?) and soria theme
| Reported by: | guest | Owned by: | Sam Foster |
|---|---|---|---|
| Priority: | high | Milestone: | 1.0 |
| Component: | Dijit - Form | Version: | 0.9 |
| Keywords: | button theme soria | Cc: | |
| Blocked By: | Blocking: |
Description
The bottom border of the button in the following example does not appear in IE7. It displays well in Firefox. If the theme is changed to tundra, it displays fine in both. The font size doesn't seem to matter, but the font does. I would attach a screen shot if that was possible.
<html>
<head>
<script type="text/javascript" src="../dojoAjax/dojo/dojo.js"
djConfig="parseOnLoad:true">
</script> <script type="text/javascript" >
dojo.require("dojo.parser");
dojo.require("dijit.form.Button");
</script>
<style type="text/css"> @import "../dojoAjax/dijit/themes/soria/soria.css";
body {
font-family: Arial;
}
</style>
</head> <body class="soria">
<div dojoType="dijit.form.Button">Hi</div>
</body>
</html>
Attachments (2)
Change History (8)
Changed 13 years ago by
| Attachment: | Button.jpg added |
|---|
comment:2 Changed 13 years ago by
| Component: | LookAndFeel → Dijit |
|---|---|
| Milestone: | → 1.0 |
| Owner: | changed from dylan to dante |
Sfoster fixed this same problem for tundra; I guess it didn't get copied over to soria? Some hack like adding zoom:1 (check the SVN log to find it).
comment:3 Changed 13 years ago by
| Status: | new → assigned |
|---|
comment:4 Changed 13 years ago by
| Owner: | changed from dante to Sam Foster |
|---|---|
| Status: | assigned → new |
buttons_4391_sfoster_20071018.patch adds a line to dijit.css to normalize line-height for the buttons. This accounts for some of the "works in the themeTester but not in the test page" issues people have reported.
the fix to tundra and soria is to style the inner contents of the button to have the inline-block behavior. This lets us set top/bottom padding and more reliably control overall button height. Tweaks follow for the outer buttonNode to get it back to where it was visually.
Changed 13 years ago by
| Attachment: | buttons_4391_sfoster_20071018.patch added |
|---|
comment:5 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:6 Changed 9 years ago by
| Component: | Dijit → Dijit - Form |
|---|
Button missing border