Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4386 closed defect (fixed)

xhr inflight watcher has bad loop logic

Reported by: sjmiles Owned by: sjmiles
Priority: high Milestone: 1.0
Component: Core Version: 0.9
Keywords: xhr, sync Cc:
Blocked By: Blocking:

Description

_watchInFlight uses dojo.forEach to iterator over the private _inFlight array. Because it also sometimes modifies that array (removes items) during iteration, the iteration is unstable (items get missed).

Primary symptom is incorrect sync behavior when an async request is inflight.

Recoding the loop using for instead of forEach makes it easy to adjust the indices as needed.

Change History (2)

comment:1 Changed 12 years ago by sjmiles

Resolution: fixed
Status: newclosed

(In [10437]) Repair _watchInFlight loop, fixes #4386.

comment:2 Changed 12 years ago by sjmiles

(In [10438]) Style faux pas, refs #4386.

Note: See TracTickets for help on using tickets.