Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#4379 closed defect (fixed)

dijit.form.Button css glitch

Reported by: Bryan Forbes Owned by: dante
Priority: high Milestone: 1.0
Component: Dijit - Form Version: 0.9
Keywords: PATCH Cc: Bryan Forbes
Blocked By: Blocking:

Description

When hovering over a button, the background shows through. This isn't a problem if the background is white (like the tests), but if it's anything other than white, it's very apparent. To demonstrate:

  1. open up dijit/tests/form/test_Button.html in Firefox
  2. use FireBug? to turn the background of the body to #000000.
  3. scroll down to the bottom of the page and hover over the button with the label "Show Hidden Buttons"

The fix is to take the color from the buttonHover.png that tundra uses and use it as the background color of the hovered element. I'm attaching a diff that does just that.

Attachments (1)

tundra-button-fix.diff (538 bytes) - added by Bryan Forbes 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by Bryan Forbes

Attachment: tundra-button-fix.diff added

comment:1 Changed 12 years ago by bill

Owner: changed from bill to dante

Giving to Dante in case this applies to soria too.

comment:2 Changed 12 years ago by dante

Status: newassigned

comment:3 Changed 12 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [10445]) checkin refs #3661 - adding unified icon nodes to Sliders, touches tundra.css and soria.css - adding in RTL styles too (though Slider is still broken functionally in RTL). fixes #4387 by adding disabled state styling to slider, and fixes #4379 by applying small patch wrt to Buttons courtesy Bryan Forbes.

comment:4 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.