Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#4370 closed enhancement (fixed)

BiDi enable TabContainer

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone: 1.0
Component: Dijit Version: 0.9
Keywords: bidi Cc: yinjun@…, hwcdl@…
Blocked By: Blocking:

Description


Attachments (2)

dijit-bidi-fix-theme-slider-tabcontainer-10425.patch (4.1 KB) - added by Adam Peller 12 years ago.
Patch from Justin Yin (IBM, CCLA). This patch only works for Firefox.
dijit-bidi-fix-tabcontainer-10431.patch (2.9 KB) - added by Adam Peller 12 years ago.
update from Justin

Download all attachments as: .zip

Change History (9)

Changed 12 years ago by Adam Peller

Patch from Justin Yin (IBM, CCLA). This patch only works for Firefox.

comment:1 Changed 12 years ago by Adam Peller

Notes from Justin: Like Slider, TabContainer? uses a so complex structure that some browsers like IE cannot handle it well in RTL direction. To completely solve this, I think maybe we need to rewrite some original implementation code in TabContainer?, which might be very risky.

Changed 12 years ago by Adam Peller

update from Justin

comment:2 Changed 12 years ago by Adam Peller

(In [10436]) TabContainer? bidi fixes. Refs #4370

comment:3 Changed 12 years ago by Adam Peller

Cc: yinjun@… hwcdl@… added

unit tests and FF look good. themeTester in IE is still broken.

comment:4 Changed 12 years ago by Adam Peller

Milestone: 1.11.0
Resolution: fixed
Status: newclosed

opened new ticket #5092 for themeTester issue

comment:5 Changed 12 years ago by Adam Peller

(In [11601]) RTL fix from Evan Huang (IBM) for right-h tab position. Refs #4370

comment:6 Changed 12 years ago by Adam Peller

(In [11607]) Fix iteration over array. Refs #4370

comment:7 Changed 11 years ago by bill

(In [13987]) Replaces JS hack w/CSS hack. Refs #4370, changesets [11601] and [11607]. !strict

Note: See TracTickets for help on using tickets.