Opened 13 years ago

Closed 13 years ago

#4363 closed enhancement (fixed)

[cla/patch/enhancement] dojox.data.FlickrRestStore implementation

Reported by: dante Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.0
Component: DojoX Data Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

preview of dojox.data.FlickrRestStore? attached - developed by Shane O'Sullivan. Needs DOH test cases, though is seemingly style-guideline-ready. extends dojox.data.FlickrStore? with caching and other things. Requested by dojox.image, though general datastore access is working.

Attachments (6)

dojox.data.patch​ (8.6 KB) - added by dante 13 years ago.
full patch
dojox.data.2.patch​ (26.8 KB) - added by dante 13 years ago.
updated patch w/ unit tests + inline documentation
dojox.data.FlickrRestStore_20070912.patch​ (27.9 KB) - added by Jared Jurkiewicz 13 years ago.
Updated patch.
dojox.data.FlickrRestStore_20070917.patch​ (28.3 KB) - added by Jared Jurkiewicz 13 years ago.
Updated patch that fixes the IE issues.
dojox.data.FlickrRestStore_search.patch​ (15.0 KB) - added by guest 13 years ago.
Implements a more comprehensive search functionality, and allows for sorting
dojox.data.FlickrRestStore_20070919.patch​ (14.6 KB) - added by Jared Jurkiewicz 13 years ago.

Download all attachments as: .zip

Change History (19)

Changed 13 years ago by dante

Attachment: dojox.data.patch​ added

full patch

comment:1 Changed 13 years ago by Jared Jurkiewicz

Patch needs unit tests before it can be considered for checkin...

comment:2 Changed 13 years ago by Jared Jurkiewicz

Any word on UT?

comment:3 Changed 13 years ago by dante

coming soon.

Changed 13 years ago by dante

Attachment: dojox.data.2.patch​ added

updated patch w/ unit tests + inline documentation

comment:4 Changed 13 years ago by dante

jared: should be good to go. unit tests pass, and patch fully integrates with dojox.data w/o problem.

Changed 13 years ago by Jared Jurkiewicz

Attachment: dojox.data.FlickrRestStore_20070912.patch​ added

Updated patch.

comment:5 Changed 13 years ago by Jared Jurkiewicz

Tested on: FireFox? 2.0.0.4 IE 6 IE 7 Safari B3 Seamonkey 1.1.2

Currently fails on IE 7. Not sure why yet.

comment:6 Changed 13 years ago by Jared Jurkiewicz

Yeah, tests fail on IE 7. Can't commit yet. Can you investigate as to why the tests are failing on IE 7?

comment:7 Changed 13 years ago by Jared Jurkiewicz

Specifically Fetch 20, Fetch paging, and isItem all fail on IE 7.

comment:8 Changed 13 years ago by Jared Jurkiewicz

Type: defect → enhancement

Changed 13 years ago by Jared Jurkiewicz

Attachment: dojox.data.FlickrRestStore_20070917.patch​ added

Updated patch that fixes the IE issues.

comment:9 Changed 13 years ago by Jared Jurkiewicz

Component: Data → DojoX Data

Tested on:

IE 7.0 IE 6.0 SeaMonkey? 1.1.2 Firefox 2.0.0.4 Firefox 1.5.0.12

comment:10 Changed 13 years ago by Jared Jurkiewicz

Resolution: → fixed
Status: new → closed

(In [10535]) Adding in import of contributed extended FlikrStore?. fixes #4363

Changed 13 years ago by guest

Attachment: dojox.data.FlickrRestStore_search.patch​ added

Implements a more comprehensive search functionality, and allows for sorting

comment:11 Changed 13 years ago by guest

Resolution: fixed
Status: closed → reopened

I added a patch, dojox.data.FlickrRestStore_search.patch, that implements much better search functionality. The store can now search against tags, sort in a number of ways, and do full text searches. A demo page has also been added. Date information is also now available for photos, both when they were taken, and when published.

Shane O'Sullivan

comment:12 Changed 13 years ago by Jared Jurkiewicz

Patch reviewed and tested on: IE 6.0 IE 7.0 Firefox 2.0.0.7 Seamonkey 1.1.2 Safari B3 Forefox 1.5.0.12

Changed 13 years ago by Jared Jurkiewicz

Attachment: dojox.data.FlickrRestStore_20070919.patch​ added

comment:13 Changed 13 years ago by Jared Jurkiewicz

Resolution: → fixed
Status: reopened → closed

(In [10562]) Updated FlickrRestStore?. fixes #4363

Note: See TracTickets for help on using tickets.