Opened 14 years ago

Closed 13 years ago

Last modified 12 years ago

#434 closed defect (fixed)

SortableTable in LayoutPane

Reported by: Dustin Machi Owned by: Tom Trenka
Priority: high Milestone:
Component: General Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

When a sortable table is put inside a layout pane, layout fun ensues!. The current SortableTable? widget wraps the given table in a div (to allow css hacks for ie). However, the properties (such as layoutAlign) that are passed to the table do not get copied to the new parent div. They layout gets confused by this.

Change History (5)

comment:1 Changed 14 years ago by Tom Trenka

Owner: changed from anonymous to Tom Trenka

Yeah, the parent div is somewhat of a hack.

How does one determine (in the widget code) if a parent widget is assigning properties/attributes to a child widget? If I had some pointers in that direction I can make this fix...

comment:2 Changed 14 years ago by bill

LayoutPane? doesn't assign properties or attributes to it's children widgets per say, but it mucks with childWidget.domNode directly. Perhaps there should be a layer of indirection. If every widget had a setPosition() or setAbsolutePosition() call, LayoutPane? could call child.setPosition(), and SortableTable? could override that function.

(It's setting the position and the size, so I'm not sure what a good function name is. Maybe setCoordinates()?)

comment:3 Changed 13 years ago by anonymous

Bill,

If you end up going that route, I think I can pull something off to make it work...I'm not totally keen on the parent div hack for the table either (and I've since decided the "bigFour" solution doesn't work, because you have to explicitly set column widths...

comment:4 Changed 13 years ago by Tom Trenka

Resolution: fixed
Status: newclosed

I just pulled the parent node hack off the widget for IE, and added a CSS hack to the test as a demonstration of how to make it work. It should work ok within Container widgets now.

comment:5 Changed 12 years ago by (none)

Milestone: 0.3release

Milestone 0.3release deleted

Note: See TracTickets for help on using tickets.