Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4327 closed defect (fixed)

SingleQuote in content using iframe transport fails

Reported by: guest Owned by: James Burke
Priority: high Milestone: 1.0
Component: General Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Having a single quote in a property of content passed to bind posts only text before single quote in IE.

This is caused by way the hidden input is created in IE:

	var tn;
	if(dojo.isIE){
		tn = dojo.doc.createElement("<input type='hidden' name='"+x+"' value='"+content[x]+"'>");
		fn.appendChild(tn);
	}else{
		tn = dojo.doc.createElement("input");
		fn.appendChild(tn);
		tn.type = "hidden";
		tn.name = x;
		tn.value = content[x];
	}

The value should be set after the element is created.

	var tn;
	if(dojo.isIE){
		tn = dojo.doc.createElement("<input type='hidden' name='"+x+"'>");
	}else{
		tn = dojo.doc.createElement("input");
		tn.type = "hidden";
		tn.name = x;
	}
	tn.value = content[x];
	fn.appendChild(tn);

This bug is also present in 0.4.x. Are we fixing bugs there anymore?

Patch is included.

schallm

Attachments (1)

iframe.patch (765 bytes) - added by guest 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by guest

Attachment: iframe.patch added

comment:1 Changed 12 years ago by James Burke

Milestone: 1.0
Owner: changed from anonymous to James Burke

comment:2 Changed 12 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [10712]) Fixes #4327. Single quotes in the value where causing trouble. Patch from schallm, CLA on file. Thank you.

comment:3 Changed 12 years ago by James Burke

Fixed in the 0.9 codebase. AFAIK, there are no plans to do another 0.4.x build.

Note: See TracTickets for help on using tickets.