Safari/Webkit: Wrong dojo._abs behavior

[haysmark]

Refer to: ​http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/form/test_ComboBox.html

When you first load test_ComboBox and open a menu, it works fine. However, if you scroll the whole page down a little and open a menu, the menu appears too high and covers the ComboBox?. Specifically, the document's scroll position is not being added to the position the popup should appear. This only affects Safari.

There seems to be a logic problem in dojo._abs. According to a console.debug I added, in FireFox? and IE, hasScroll is false and everything displays correctly. In Safari, hasScroll becomes true, which seems to trigger the wrong math at this section:

var scroll = dojo._docScroll();
var m = hasScroll ? (!includeScroll ? -1 : 0) : 1;
ret.y += m*scroll.y;
ret.x += m*scroll.x;

The dojo.coords call is in place.js in dijit:

var aroundNodePos = dojo.coords(aroundNode, true);

[guest]

Hi all

I'm gathering from the following comment in dojo.js.uncompressed.js that this could have something to do with a change in behaviour in Safari.

// FIXME: getting contrary results to the above in latest WebKit.

I'm attaching a patch that fixes the problem for me.

cheers

Hannes

[alex]

(In [11115]) add spacing for Safari. Fixes #4325

[bill]

I just tried the test case on safari (see bug description) and it isn't working. Same for webkit, btw.

[bill]

Perhaps the problem is just that the above patch has the line dojo.isSafari >= 5, whereas actually safari's is version 3 (and indeed on Safari version 3, dojo.isSafari == 3)

[haysmark]

Yeah let's try to keep this fixed for 1.0.1.

[bill]

(In [11589]) Fixes #4325 on 1.0 branch: typo in safari version number about messing up dojo.abs() and thus drop down/popup placement

[bill]

(In [11590]) Fixes #4325 on trunk: typo in safari version number about messing up dojo.abs() and thus drop down/popup placement