#4322 closed enhancement (fixed)
Support labels on indeterminate progress bars
Reported by: | simonjb | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 1.6 |
Component: | Dijit | Version: | 0.9 |
Keywords: | Cc: | bill, dante, Adam Peller, davidb | |
Blocked By: | Blocking: |
Description (last modified by )
Support labels on indeterminate progress bars.
Requesting for the mail demo. See source:/dijit/trunk/demos/mail.html " FIXME: can't set a label on an indeterminate progress bar."
To make the label available to assistive technologies, we should be able to use the aria "describedby" property (and leave the "valuenow" unset).
Attachments (1)
Change History (16)
comment:1 Changed 13 years ago by
Milestone: | 1.0 → 1.1 |
---|
comment:2 Changed 13 years ago by
comment:3 Changed 13 years ago by
Milestone: | 1.1 → 1.2 |
---|
comment:4 Changed 13 years ago by
Cc: | davidb added |
---|---|
Owner: | changed from simonjb to Joseph Scheuhammer |
comment:5 Changed 12 years ago by
Description: | modified (diff) |
---|
Any update on this one? Punt to future?
comment:6 Changed 12 years ago by
Milestone: | 1.2 → 1.3 |
---|
bump enhancements to next milestone, as we prepare to close out 1.2
comment:7 Changed 12 years ago by
Milestone: | 1.3 → 1.4 |
---|
bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4
comment:9 Changed 11 years ago by
Milestone: | 1.4 → 1.5 |
---|---|
Owner: | changed from Joseph Scheuhammer to dante |
Status: | new → assigned |
I've wanted this forever. I'll talk to becky and figure out if the above solutions are still valid.
comment:10 Changed 11 years ago by
Milestone: | 1.5 → future |
---|
comment:11 Changed 11 years ago by
Milestone: | future → 1.6 |
---|
patch attached for 1.6/trunk, please review (@bill, @becka11y)
comment:12 Changed 11 years ago by
Hi Pete, thanks for working on the patch. There are a couple things I want to do differently so I'm going to check in a modified version of your patch.
- should call it "label" not "labelText", to be consistent w/the rest of dijit. (unfortunately have to change dojoAttachPoint="label" to dojoAttachPoint="labelNode")
- should be able to set the label on creation too, not just afterwards, via
new ProgressBar({label: ...})
or equivalent markup - changing the label should be done via set("label", ...), not update(). (changing the determinate/indeterminate status, and the progress percentage value should also be done via set(), there will probably be some refactoring for that as part of #11251)
- instead of messing with class names and visibility:hidden / visibility:visible, just make the default label as
comment:13 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
May be able to use aria-valuetext attribute. see #5783