Support labels on indeterminate progress bars

[simonjb]

Support labels on indeterminate progress bars.

Requesting for the mail demo. See source:/dijit/trunk/demos/mail.html " FIXME: can't set a label on an indeterminate progress bar."

To make the label available to assistive technologies, we should be able to use the aria "describedby" property (and leave the "valuenow" unset).

[Becky Gibson]

May be able to use aria-valuetext attribute. see #5783

[dylan]

Any update on this one? Punt to future?

[bill]

bump enhancements to next milestone, as we prepare to close out 1.2

[bill]

bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4

[Adam Peller]

bump

[dante]

I've wanted this forever. I'll talk to becky and figure out if the above solutions are still valid.

[dante]

adds support tests and docs

[dante]

patch attached for 1.6/trunk, please review (@bill, @becka11y)

[bill]

Hi Pete, thanks for working on the patch. There are a couple things I want to do differently so I'm going to check in a modified version of your patch.

• should call it "label" not "labelText", to be consistent w/the rest of dijit. (unfortunately have to change dojoAttachPoint="label" to dojoAttachPoint="labelNode")
• should be able to set the label on creation too, not just afterwards, via new ProgressBar({label: ...}) or equivalent markup
• changing the label should be done via set("label", ...), not update(). (changing the determinate/indeterminate status, and the progress percentage value should also be done via set(), there will probably be some refactoring for that as part of #11251)
• instead of messing with class names and visibility:hidden / visibility:visible, just make the default label as  

[bill]

(In [22522]) User customizable label on ProgressBar, fixes #4322 !strict. It's unclear why we used to set visibility:hidden on the progress bar label, rather than just inserting an &nbsp. (Need to do something though so the ProgressBar doesn't have 0 height.)

[bill]

(In [22523]) Changing doc/tests to indicate that set() is the preferred interface for changing percent, label, indeterminate mode, etc. Refs #4322 !strict.

[bill]

(In [22614]) make tests about custom label (for both determinate and indeterminate progress bar) clearer, refs #4322, #11496.