Opened 12 years ago

Closed 9 years ago

Last modified 9 years ago

#4322 closed enhancement (fixed)

Support labels on indeterminate progress bars

Reported by: simonjb Owned by: dante
Priority: high Milestone: 1.6
Component: Dijit Version: 0.9
Keywords: Cc: bill, dante, Adam Peller, davidb
Blocked By: Blocking:

Description (last modified by dylan)

Support labels on indeterminate progress bars.

Requesting for the mail demo. See source:/dijit/trunk/demos/mail.html " FIXME: can't set a label on an indeterminate progress bar."

To make the label available to assistive technologies, we should be able to use the aria "describedby" property (and leave the "valuenow" unset).

Attachments (1)

progress.patch (4.1 KB) - added by dante 9 years ago.
adds support tests and docs

Download all attachments as: .zip

Change History (16)

comment:1 Changed 12 years ago by simonjb

Milestone: 1.01.1

comment:2 Changed 11 years ago by Becky Gibson

May be able to use aria-valuetext attribute. see #5783

comment:3 Changed 11 years ago by simonjb

Milestone: 1.11.2

comment:4 Changed 11 years ago by simonjb

Cc: davidb added
Owner: changed from simonjb to Joseph Scheuhammer

comment:5 Changed 11 years ago by dylan

Description: modified (diff)

Any update on this one? Punt to future?

comment:6 Changed 11 years ago by bill

Milestone: 1.21.3

bump enhancements to next milestone, as we prepare to close out 1.2

comment:7 Changed 10 years ago by bill

Milestone: 1.31.4

bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4

comment:8 Changed 10 years ago by Adam Peller

bump

comment:9 Changed 10 years ago by dante

Milestone: 1.41.5
Owner: changed from Joseph Scheuhammer to dante
Status: newassigned

I've wanted this forever. I'll talk to becky and figure out if the above solutions are still valid.

comment:10 Changed 9 years ago by dante

Milestone: 1.5future

Changed 9 years ago by dante

Attachment: progress.patch added

adds support tests and docs

comment:11 Changed 9 years ago by dante

Milestone: future1.6

patch attached for 1.6/trunk, please review (@bill, @becka11y)

comment:12 Changed 9 years ago by bill

Hi Pete, thanks for working on the patch. There are a couple things I want to do differently so I'm going to check in a modified version of your patch.

  • should call it "label" not "labelText", to be consistent w/the rest of dijit. (unfortunately have to change dojoAttachPoint="label" to dojoAttachPoint="labelNode")
  • should be able to set the label on creation too, not just afterwards, via new ProgressBar({label: ...}) or equivalent markup
  • changing the label should be done via set("label", ...), not update(). (changing the determinate/indeterminate status, and the progress percentage value should also be done via set(), there will probably be some refactoring for that as part of #11251)
  • instead of messing with class names and visibility:hidden / visibility:visible, just make the default label as  

comment:13 Changed 9 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [22522]) User customizable label on ProgressBar, fixes #4322 !strict. It's unclear why we used to set visibility:hidden on the progress bar label, rather than just inserting an &nbsp. (Need to do something though so the ProgressBar doesn't have 0 height.)

comment:14 Changed 9 years ago by bill

(In [22523]) Changing doc/tests to indicate that set() is the preferred interface for changing percent, label, indeterminate mode, etc. Refs #4322 !strict.

comment:15 Changed 9 years ago by bill

(In [22614]) make tests about custom label (for both determinate and indeterminate progress bar) clearer, refs #4322, #11496.

Note: See TracTickets for help on using tickets.