Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#432 closed defect (fixed)

FloatingPane should refer to it's widgetType by property not fixed string

Reported by: anonymous Owned by: anonymous
Priority: low Milestone:
Component: Widgets Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

I need to subclass FloatingPane? to change some minor behavior. I created FloatingPaneImpl? in my package and use it.

The bringToTop method however does not work because it has it's widgetType hardcoded to "FloatingPane?" and my widgets are of type "FloatingPaneImpl?".

Line 422 in 0.2.2 var floatingPanes= dojo.widget.manager.getWidgetsByType("FloatingPane?");

could be var floatingPanes= dojo.widget.manager.getWidgetsByType(this.widgetType);

to eliminate requiring duplication of this method to change widgetType.

Change History (4)

comment:1 Changed 14 years ago by anonymous

Also should check other widgets for similair hard coded widgetType strings to ease subclassing.

comment:2 Changed 14 years ago by bill

How about if dojo.widget.manager.getWidgetsByType returned all subclasses of the specified type too? Then it would work. (But I agree the name shouldn't be hardcoded)

comment:3 Changed 14 years ago by bill

Resolution: fixed
Status: newclosed

Fixed in #2047

comment:4 Changed 12 years ago by (none)

Milestone: 0.3release

Milestone 0.3release deleted

Note: See TracTickets for help on using tickets.