Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4312 closed defect (fixed)

Stack key navigation events refactor

Reported by: davidb Owned by: davidb
Priority: high Milestone: 1.0
Component: Dijit Version: 1.0
Keywords: Cc: Becky Gibson
Blocked By: Blocking:

Description (last modified by davidb)

Focus should go to the tab button when there is a page change. Navigation based key handling for page changes, deletes should be processed in one place (ideally) as opposed to separate container and controller processing.

(Note eventually we might use KeyNavContainer? for stack impl)

Attachments (1)

4312.diff​ (4.4 KB) - added by davidb 12 years ago.
reduces code size by 14 lines. moves all key handling code to one place. makes behaviour tweaks as per becky chat

Download all attachments as: .zip

Change History (12)

comment:1 Changed 12 years ago by Adam Peller

Owner: set to davidb

comment:2 Changed 12 years ago by davidb

Status: new → assigned

comment:3 Changed 12 years ago by davidb

Summary: StackContainer should receive unswallowed keyboard events from container area. → Stack controller should receive unswallowed keyboard events from container area.

Changed 12 years ago by davidb

Attachment: 4312.diff​ added

reduces code size by 14 lines. moves all key handling code to one place. makes behaviour tweaks as per becky chat

comment:4 Changed 12 years ago by davidb

Cc: Becky Gibson added
Description: modified (diff)
Summary: Stack controller should receive unswallowed keyboard events from container area. → Key navigation events refactor

comment:5 Changed 12 years ago by davidb

Summary: Key navigation events refactor → Stack key navigation events refactor

comment:6 Changed 12 years ago by davidb

Resolution: → fixed
Status: assigned → closed

(In [10557]) Fixes #4312: reduces code size by 14 lines. moves all key handling code to one place. makes behaviour tweaks as per becky chat

comment:7 Changed 12 years ago by davidb

(In [10558]) Refs #4312, reverting until conflicts with stackcontainer test are resolved.

comment:8 Changed 12 years ago by davidb

Resolution: fixed
Status: closed → reopened

comment:9 Changed 12 years ago by davidb

Resolution: → fixed
Status: reopened → closed

(In [10559]) Fixes #4312: reduces code size. moves all key handling code to one place. makes behaviour tweaks as per becky chat. (reinstated forward/backward api used in test_StackContainer.html)

comment:10 Changed 12 years ago by Adam Peller

(In [10563]) More reductions and style fixes. Refs #4312

comment:11 Changed 12 years ago by davidb

(In [10988]) Fixes #4787: reintroduces layout function, removes old incorrect layout comment, removes some cruft. (Refs #4312)

Note: See TracTickets for help on using tickets.