Opened 12 years ago

Closed 12 years ago

#4304 closed defect (invalid)

1.0: dojo.data.util.simpleFetch mixin isn't passing null to onComplete when onItem is being used.

Reported by: Jared Jurkiewicz Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.0
Component: Data Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

1.0: dojo.data.util.simpleFetch mixin isn't passing null to onComplete when onItem is being used.

This is a minor spec deviation that needs to be fixed. The API states that if the onItem callback is passed, then onComplete will be passed a null for the items array. This is because onItem callback setting assumes streaming approach to data handling whereas onComplete is chunked. You use one or the other. In the case of onItem, onComplete just denotes when all items have been returned.

Trivial fix (1 liner). Needs testcase for this case as well to verify it does not regress again in the future.

Change History (2)

comment:1 Changed 12 years ago by Jared Jurkiewicz

Actually, duh, this already works. I relooked at the code on how it's handled and it's already Ut;'ed, too! Nothing to fix here. Invalid bug. :-)

comment:2 Changed 12 years ago by Jared Jurkiewicz

Resolution: invalid
Status: newclosed
Note: See TracTickets for help on using tickets.