Opened 14 years ago
Closed 14 years ago
#4285 closed defect (fixed)
title bar focus needs to be more noticeable
Reported by: | Becky Gibson | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 1.0 |
Component: | Accessibility | Version: | 0.9 |
Keywords: | Cc: | Becky Gibson, owen, Sam Foster, davidb | |
Blocked By: | Blocking: |
Description
It is very difficult to determine when the title bar gets focus. Can we do something visually? Either a different color background, a more prominent focus border, or even just bolding and changing the color of the text.
Attachments (1)
Change History (9)
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
Status: | new → assigned |
---|
works in firefox, but probably not ie.
.tundra div.dijitTitlePaneTitle:focus { border:1px solid #666; }
ie6 seems to have a dotted border to indicate focus. focus style is murky water, and will be very difficult to unify across widgets.
an additional "dijitFocused" class attached to the outlying node of templated widgets would help: would be able to apply styles based on class only, nor relying on pseudo-selectors that don't work in all browsers.
comment:3 Changed 14 years ago by
Be careful about attaching dijitFocused to TitlePane?.domNode as it will trickle down to affect all the contained widgets... but sure, it's a good idea to have a class on the title bar itself. The form widgets already apply a class (there's some code in focus.js::_onFocusNode() to call setStateClass() on focus/blur)
comment:4 Changed 14 years ago by
Cc: | Becky Gibson owen Sam Foster davidb added; becky owen sfoster removed |
---|
comment:5 Changed 14 years ago by
I've created an additional ticket, #4442, for accordion pane title. Hopefully we can use a similar solution for both.
comment:6 Changed 14 years ago by
added a patch to fix this and #4222 - not sure about the this.inherited changes. tested here, but href was breaking because of no php locally so the "cleanup" aspect of patch to TitlePane?.js may be unacceptable.
comment:8 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
I assigned to dante but I am willing to handle this if one of the designers can let me know what mechanism to use to distinguish focus better.