Opened 12 years ago

Closed 12 years ago

#4283 closed defect (fixed)

Dialog: regression in [10361]

Reported by: dante Owned by: bill
Priority: high Milestone: 1.0
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by haysmark)

[10361] broke Dialog with href. The ContentPane? code does not load the data. In ContentPane?._loadCheck, it checks to see if you defined an open variable, which this checkin adds for Dialog. Because open is false when Dialog calls _loadCheck, ContentPane? thinks it is closed and bad things happen.

Before this revision, open was not defined so ContentPane? always opened.

Moving the open=true before the _loadCheck call in Dialog.show should fix it and cause the load to occur.

Change History (7)

comment:1 Changed 12 years ago by dante

Cc: haysmark added; hayesmark removed
Description: modified (diff)

dyslexics of the world untie.

comment:2 Changed 12 years ago by haysmark

Summary: Dialog: regression in [10354]Dialog: regression in [10345]

comment:3 Changed 12 years ago by haysmark

Cc: haysmark removed
Description: modified (diff)
Summary: Dialog: regression in [10345]Dialog: regression in [10361]

I changed the description to indicate what is really going on here. My revision did not break anything, but dante's [10361] sure did.

comment:4 Changed 12 years ago by dante

Owner: changed from bill to dante
Status: newassigned

no, my checkin (done on 8/26) was done after this ticket was filed, and after i was seeing the behavior. Scanning through arhive.dojotoolkit.org, I thought I placed the breakage in or around [10345] ...

http://archive.dojotoolkit.org/dojo-2007-08-21/checkout/dijit/tests/test_Dialog.html

works, though tooltip from href doesn't.

http://archive.dojotoolkit.org/dojo-2007-08-22/checkout/dijit/tests/test_Dialog.html

'show dialog' link shows no dialog (but does an underlay), href dialog does the same.

href dialog seems to work again in on 8-24 nightly, though tooltip from href does not. I think I just confused my non-working local copy with what was currently broken in nightlies. but you are right about the open: attrib. will fix that ASAP. the issue still existed before [10361]

comment:5 Changed 12 years ago by dante

(In [10365]) refs #4283 - haysmark was right, needed to set open = true before _LoadCheck in Dialog.show() ... behavior now is: on 'slow loading href' dialog, after is shown, right edge attaches itself to right edge of viewport, and does not move on drag, but rather resizes, always staying attached to right edge of screen. not even bothering to determine when in nightlies this occured. suspect it has something to do with the width of the dialog.

tooltip from href still doesn't work (which was i believe part of the original ticket).

comment:6 Changed 12 years ago by dante

Owner: changed from dante to bill
Status: assignednew

giving this back to bill - note: Tooltip from href still not working, and was part of the orig ticket desc. so you might want to just close this and file a new one?

Dialog from href 'works' again, though see notes attached to [10365] wrt sizing.

comment:7 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

OK, TooltipDialog? problem filed as #4340, and Dialog/href sizing problem filed as #4341.

Note: See TracTickets for help on using tickets.