#4282 closed defect (fixed)
Tooltip: places the tooltips wrong when window is very small.
Reported by: | guest | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.6 |
Component: | Dijit | Version: | 0.9 |
Keywords: | Tooltip | Cc: | Katie Vance |
Blocked By: | Blocking: |
Description (last modified by )
Test the following example. Make the window very small so that the lines in the tooltip and from the text right to the checkboxes will be broken. The tooltip will be positioned far away from the checkbox.
Attachments (5)
Change History (30)
comment:1 Changed 14 years ago by
Milestone: | → 1.1 |
---|
comment:2 Changed 14 years ago by
Owner: | set to bill |
---|
comment:3 Changed 13 years ago by
Description: | modified (diff) |
---|---|
Milestone: | 1.1 → 1.2 |
comment:4 Changed 13 years ago by
Description: | modified (diff) |
---|---|
Milestone: | 1.2 → 1.4 |
Summary: | Tooltip places the tooltips wrong when window is very small. → Tooltip: places the tooltips wrong when window is very small. |
Changed 13 years ago by
put in root directory, next to dojo/ and dijit/
comment:5 Changed 12 years ago by
Milestone: | 1.4 → future |
---|
comment:6 Changed 11 years ago by
Milestone: | future → 1.6 |
---|
comment:7 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [22969]) Tooltip positioning fixes:
- Before positioning tooltip, limit tooltip's width to available width between the around node and the edge of the viewport. Reducing a tooltip's width (for tooltips with flowing text) will increase the tooltip's height, which affects vertical placement.
- Position tooltip connector arrow to line up with the around node, even when tooltip (due to a large tooltip size/small viewport size) extends both above and below the around node.
- Fix problem with tooltip placement when clicking a TextBox causes it to scroll into view simultaneously with displaying a tooltip.
Note: To determine the "natural" width of a toolip, had to remove left:50% setting for offscreen tooltips, because offscreen tooltips still get limited in width to the edge of the viewport. That CSS was apparently to work around a bug in an old browser (but no longer happens in the browsers we support).
Patch from Katie Vance (IBM, CCLA), thanks!
Known issues: regression test failing by a few pixels on Mac FF (but working on Windows FF).
comment:8 Changed 11 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Bill, the new Tooltip_placement test has a lot of redundant test case declarations. I attached a patch to make the test file more maintainable.
comment:9 Changed 11 years ago by
Cc: | Katie Vance added |
---|
comment:10 Changed 11 years ago by
Yes before [22995] I was getting a few failures because the tooltip wasn't appearing on screen for very long textboxes. Now the _abs and _ab tests systematically fail for me.
Changed 11 years ago by
Attachment: | 4282.patch added |
---|
Fixes #4282. Refactor Tooltip_placement to use 1/5th the LOC.
comment:11 Changed 11 years ago by
I fixed those 4 failures and reattached the patch. It turned out that one of the textboxes wasn't supposed to be tested, so 1 textbox*4 groups=4 failures. Also, sometimes I noticed the robot took an extremely long time to click the above,below button; this would cause the _abs and _ab tests to fail. Restarting the browser fixed it for me.
comment:12 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:13 Changed 11 years ago by
comment:14 Changed 11 years ago by
comment:15 Changed 11 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Doug, I like the idea of using <br>'s. I think it may have uncovered a real bug. However, we still need the tooltips to have more content because they must span the entire width available in order to test the main test case. Making them as small as you did caused the tests to fail on a normal size window. I'm attaching a patch to make them just a bit larger. The patch also addresses a bug I found after I resized the tooltips.
comment:16 Changed 11 years ago by
I'm also seeing the tests fail on IE8. I think my browser is running the last sets of tests so fast that they are validating the placement of the tooltip before the tooltip is placed. I will look into that tomorrow.
comment:17 Changed 10 years ago by
place13.patch is a cumulative patch that includes patches 11 and 12. I deleted both patches for 11 & 12 for that reason.
comment:18 Changed 10 years ago by
The new placement tests require a min browser size of 500px X 500px. Any smaller and some of the very small tooltips will be forced to overlap textboxes and fail tests because of the new nowrap behavior. Only the nowrap tests are allowed to overlap textboxes.
Changed 10 years ago by
Attachment: | place13.patch added |
---|
This new patch runs on 400X400 min browser size.
comment:19 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:20 Changed 10 years ago by
comment:21 Changed 10 years ago by
(In [23520]) Don't let bottom of tooltip connector extend past bottom of tooltip content, as it makes the tooltip look broken. Problem occurred with <14px tall aroundNodes such as points on charts.
Would be better to center the tooltip content relative to the center of the aroundNode, rather than the current behavior where their bottoms are aligned. With this checkin, for small aroundNodes (such as points on charts) the connector doesn't quite vertically align with the aroundNode.
I had to update your test file some (attached the new version) but I am able to reproduce.