Opened 15 years ago

Closed 15 years ago

#4261 closed defect (fixed)

[10334] breaks dialog placement...

Reported by: guest Owned by: haysmark
Priority: high Milestone: 1.0
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Bill's change to place.js breaks the dijit dialog on FF. I don't know if the problem is w/ dialog or with place.js but reverting the change makes dialog work again.

[email protected]…

Change History (4)

comment:1 Changed 15 years ago by guest

[10334]

comment:2 Changed 15 years ago by bill

Milestone: 0.9 → 1.0
Owner: set to haysmark

Hmm, although the mail demo is working ​http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/test_Dialog.html seems broken (on FF mac). The changeset you mentioned [10334] is from Mark, not me, so I'm assigning the bug to him.

comment:3 Changed 15 years ago by haysmark

Status: new → assigned

comment:4 Changed 15 years ago by bill

Resolution: → fixed
Status: assigned → closed

(In [10345]) Addresses regression from [10334] in Dialog by more properly getting the viewport minus the scrollbar with a combination of documentElement.clientHeight and body.clientHeight. Fixes #4261.

Patch from Mark Hays (IBM, CCLA on file)

Note: See TracTickets for help on using tickets.