[CLA] multiple input values with the same name get clobbered by dojo.formToObject

[guest]

Consider:

<form name='abc'>
<input name='q' value='a'>
<input name='q' value='b'>
<input name='q' value='c'>
</form>

The browser will send:

q=a&q=b&q=c

formToObject produces:

q=a

because the ret[] array (internal to formToObject) does not take into account the multiple values unless your form has a multiple=true attribute on the select.

DISCUSSION:

I think you want to do what the browser would do in the formToObject code. If I hit submit or I use xhrPost, I would want the back-end code to do the same thing without special-casing.

RELAVANCE:

It turns out that PHP has a notion for array posting that takes multiple values of an input and crushes them into an array if they are formatted as a[]. So to get a list of names for a party you could do something like:

<input type='text' name='name[]'>

and then copy that input tag and duplicate it verbatim (via, say, DHTML) to get an array with several names.

The patch is below and my CLA is on file with dojo.

dojo@…

[guest]

diff (cla on file)

[guest]

diff worked on the 2nd post (formtoobject.diff)

[guest]

cla on file

[tk]

Adding a CC for someone else thats watching for this bug fix.

[tk]

fixing CC... my bad.

[tk]

verified CLA, just need the patch reviewed and imported.

[James Burke]

(In [10458]) Fixes #4259 and #4330. Fixes for form values with multiple names and for selects with multiple selected options