Opened 13 years ago
Closed 13 years ago
#4240 closed defect (fixed)
DeferredList errors
Reported by: | Bryan Forbes | Owned by: | Dustin Machi |
---|---|---|---|
Priority: | high | Milestone: | 1.0 |
Component: | Core | Version: | 0.9 |
Keywords: | Cc: | Dustin Machi | |
Blocked By: | Blocking: |
Description (last modified by )
I have found three big bugs:
- DeferredList? throws an error about _cbDeferred not being a function. This is because there is no scope given on the addCallback and addErrback in lines 30 and 31.
- The original callbacks don't get anything to their arguments because the addCallback and addErrback functions in lines 30 and 31 don't return anything.
- The DeferredList?'s callback is fired before the last deferred's callback is called.
Attachments (1)
Change History (8)
comment:1 Changed 13 years ago by
Description: | modified (diff) |
---|---|
Summary: | DeferredList throws an error about this not having a _cbDeferred function → DeferredList errors |
Changed 13 years ago by
Attachment: | DeferredList.diff added |
---|
comment:2 Changed 13 years ago by
Cc: | Dustin Machi added |
---|---|
Owner: | changed from Bryan Forbes to sjmiles |
comment:3 Changed 13 years ago by
Owner: | changed from sjmiles to alex |
---|
Not sure why this got assigned to me, I think it belongs to either dmachi or alex.
comment:4 Changed 13 years ago by
Milestone: | 0.9 → 1.0 |
---|
comment:5 Changed 13 years ago by
Owner: | changed from alex to Dustin Machi |
---|
comment:6 Changed 13 years ago by
1 has already been fixed in a checkin earlier today. 3 is the spec'd behavior (the callbacks are attached to the callback chain of the individual deferreds at the time the list is created. I'll incorporate your changes for 2.
comment:7 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
I have attached a patch that fixes 1 and 2. I also simplified the forEach loop in the process. This, however, does not fix 3. I added a unit test file with two tests. The first (if run before the patch to DeferredList?.js) shows 1 and 2. The second shows 3.