Opened 12 years ago

Closed 12 years ago

#4239 closed enhancement (fixed)

dojo.fx.slideTo calls getComputedStyle multiple times.

Reported by: jonu Owned by: Bryan Forbes
Priority: high Milestone:
Component: fx Version: 0.9
Keywords: slideTo speed Cc:
Blocked By: Blocking:

Description

slideTo called getComputedStyle multiple times, and sometimes when it didn't need the computed style at all.

We could improve the performance, probably.

dojo 0.9 - svn rev 10315

Attachments (1)

slideto_perf.patch​ (726 bytes) - added by guest 12 years ago.
A patch that improves the speed of fx.slideTo.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by guest

Attachment: slideto_perf.patch​ added

A patch that improves the speed of fx.slideTo.

comment:1 Changed 12 years ago by jonu

This patch is mine. My CLA is on file.

comment:2 Changed 12 years ago by jonu

Keywords: slideTo speed added
Reporter: changed from guest to jonu

comment:3 Changed 12 years ago by Bryan Forbes

Resolution: → wontfix
Status: new → closed

Although this might improve the speed of the setup of dojo.fx.slideTo, it won't improve the speed or rendering of the animation. Also, the computed style function in those trinary operators doesn't get called until the condition gets evaluated to false.

comment:4 Changed 12 years ago by Bryan Forbes

Resolution: wontfix
Status: closed → reopened

Reopening because the init function needs revamping and I found a way to only call getComputedStyle once.

comment:5 Changed 12 years ago by Bryan Forbes

Resolution: → fixed
Status: reopened → closed

(In [10707]) fixes #4239 - code size reduction and optimization for dojo.fx.slideTo.

Note: See TracTickets for help on using tickets.