Opened 12 years ago
Closed 12 years ago
#4191 closed defect (duplicate)
[CLA-patch] _Templated.js loses DOM id
| Reported by: | guest | Owned by: | |
|---|---|---|---|
| Priority: | high | Milestone: | 1.0 |
| Component: | Dijit | Version: | 0.9 |
| Keywords: | Cc: | [email protected]… | |
| Blocked By: | Blocking: |
Description
Any dijit widget using a template loose it's DOM id:
http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/test_TitlePane.html
You'll notice the second pane doesn't have a DOM id anymore but only: widgetid="pane_2"
Attachments (1)
Change History (3)
Changed 12 years ago by
| Attachment: | template.patch added |
|---|
comment:1 Changed 12 years ago by
This is potentially a dup of #3058, which seeks to provide carryover for attributes in the general case, while still providing the ability for templates to set them. Bill had some issue with us referencing srcNodeRef in this manner in _Templated also, though I'm not sure what it was. #3058 attempts to address all of this, but I couldn't get it working with some of the more complex widgets in time for 0.9 (multiple inheritance, widgets in widgets) It's checked into a branch, for now.
comment:2 Changed 12 years ago by
| Milestone: | 0.9 → 1.0 |
|---|---|
| Resolution: | → duplicate |
| Status: | new → closed |
Right, as Adam said the patch violates one of Dijit's axioms: a widget must get it's parameters from the parser, never by directly accessing srcNodeRef. But (also as Adam said) it will be fixed with #3058. (Also note that id is already copied to most of the widgets; there are just a few where we forgot to copy it.)
1 line fix