Opened 12 years ago

Closed 8 years ago

Last modified 8 years ago

#4163 closed defect (fixed)

strip all whitespace from flattened nls resources

Reported by: Adam Peller Owned by: Rawld Gill
Priority: high Milestone: 1.8
Component: BuildSystem Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by James Burke)

for example, in nls/dijit-all_en.js, I see:

dojo.nls.colors.en={"light
steelblue": "light steel blue", "orangered": "orange red", ...

I would expect the tools to strip out the spaces after each ":" and "," and perhaps the newlines, too. Ideally, this would happen by default, with or without an optimize setting, to parallel what's done for the bundles themselves.

Change History (8)

comment:1 Changed 12 years ago by Adam Peller

Description: modified (diff)

comment:2 Changed 12 years ago by James Burke

Milestone: 1.02.0

comment:3 Changed 12 years ago by alex

Milestone: 2.01.3

Milestone 2.0 deleted

comment:4 Changed 11 years ago by James Burke

Description: modified (diff)
Milestone: 1.3future

comment:5 Changed 8 years ago by ben hockey

Owner: changed from James Burke to Adam Peller
Status: newpending

is this ticket still relevant with the amd loader and build?

i'm setting this ticket to pending which will mean it will automatically close in 14 days if there is no response.

comment:6 Changed 8 years ago by Adam Peller

Owner: changed from Adam Peller to Rawld Gill
Status: pendingassigned

whitespace and comments remain in the flattened bundles (as well as in the individual resources in a standard build -- since AMD is more likely to use individual modules, should the default be to compress them also?)

comment:7 Changed 8 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

In [28471]:

checked and updated builder code to conform with dojo style sheet; aligned URL resolution algorithm between loader and builder; cleaned crufty builder modules writeAmd, text, i18n; fixes #14005; fixes #4163; !strict

comment:8 Changed 8 years ago by bill

Milestone: future1.8
Note: See TracTickets for help on using tickets.