Menu2 menu items run application "onclick" even if disabled

[[email protected]…]

The Menu2 widget doesn't seem to provide for properly disabling application-specific actions when the item is disabled. The widget's onclick code properly avoids opening a submenu (if there is one), but doesn't control app-specific actions.

My proposal is to add a new event/method, which might be named "onChoose", and calling it from the widget's onclick code only when the menu item is enabled. Applications then attach actions to the "onChoose" event. My change as a patch:

@@ -497,8 +497,14 @@
 
                        this.parent.closeAll();
                }
+                this.onChoose();
        },
 
+        onChoose: function(){
+
+          // placeholder for application actions
+        },
+
        highlightItem: function(){
 
                dojo.html.addClass(this.domNode, 'dojoMenuItem2Hover');

[bill]

Ilia updated MenuItem2 to use topics. onClick() calls

dojo.event.topic.publish(this.eventNames.engage, this);

(but only when enabled). But I'm not sure how you set the name of the event. By default, this.eventNames.engage=="". Ilia, can you explain?

[bill]

Fixed in rev 3032.

[bill]

From mail:

Yeah, I agree that

<div dojoType="MenuItem2" onClick="alert('hello world');">

is definitely a more compact syntax than using topics, especially since you can do everything in markup.

I think in the non-dojo case below, the onClick event WON'T get fired, right?

<button disabled="true" onClick="alert('hello world');">push me</button>

So, I've done the same for menu items.

[(none)]

Milestone 0.3release deleted