Opened 12 years ago

Closed 12 years ago

#4142 closed defect (fixed)

Disconnect package returned from connect references the listener object

Reported by: sjmiles Owned by: sjmiles
Priority: high Milestone: 0.9
Component: Core Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

For convenience, the return value from connect (aka the "disconnect package") contains a reference to the listener machine that was chosen for the connection.

If client code connects the disconnect package back to the node and does not remove it, it can cause a leak (see dijit.menu.bindDomNode).

Suggest DOM-unified connect (event.js) use a listener identifier instead of a direct reference to prevent this effect.

Change History (3)

comment:1 Changed 12 years ago by sjmiles

Status: newassigned

comment:2 Changed 12 years ago by sjmiles

Milestone: 0.9

comment:3 Changed 12 years ago by sjmiles

Resolution: fixed
Status: assignedclosed

(In [10187])
Aggressive leak protection on IE7 (which is more broken than we had hoped), fixes #4141.

Indirect listener from disconnect package, fixes #4142.

Remove closure over 'node' in _fixCallback on IE, fixes #4159.

Key hack to normalize arrow and page keys on Safari for Windows, fixes #4129.

Note: See TracTickets for help on using tickets.