Opened 12 years ago

Closed 12 years ago

#4133 closed defect (fixed)

Tundra: theme for TimePicker widget

Reported by: haysmark Owned by: dante
Priority: high Milestone: 1.0
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Right now the TimePicker? widget is missing classes and looks a little odd. See the Java applet in #599 to get an idea of how it is supposed to look. The nonlabeled times are supposed to be smaller than the labeled times.

Attachments (1)

timepicker.patch (10.0 KB) - added by dante 12 years ago.
some changes?

Download all attachments as: .zip

Change History (8)

comment:1 Changed 12 years ago by haysmark

Component: LookAndFeelDijit

comment:2 Changed 12 years ago by bill

Milestone: 1.01.1
Owner: changed from itorrey to dante

Will do for 1.1, or maybe we'll just deprecate TimePicker? in favor of dojox.TimeSpinner?. Needs some thought.

comment:3 Changed 12 years ago by haysmark

If we are delaying this for 1.1 wouldn't we necessarily have to get this time spinner in place? I would think that we would either style all of our 1.0 widgets or just not include them.

comment:4 Changed 12 years ago by dante

TimePicker? was in 0.9 so we can't drop it for 1.0 anyway (right?). I vote look at dojox.widget.TimeSpinner? for a11y compliance, and include it in dijit now, and I will try to get to TimePicker? before 1.0 but [my] time is limited and it may be unrealistic.

Changed 12 years ago by dante

Attachment: timepicker.patch added

some changes?

comment:5 Changed 12 years ago by dante

(In [10953]) refs #4133 - serious style and code changes to _Picker and TimeTextBox?. intriuces ie6 regression regarding popup width and offsetWidth ... but is in much better working state.

adds testcase for TimeTextBox?, too. no tundra styling. all work is being done in dijit.css atm - defer to dijit experts on how to break out styling, and still needs more tundra-eqsue styling some.

comment:6 Changed 12 years ago by bill

(In [10966]) Split off DateTextBox? tests to a separate file, like TimeTextBox?. Also, rename test_TimePicker.html to test_TimeTextBox.html. Refs #4133.

comment:7 Changed 12 years ago by bill

Milestone: 1.11.0
Resolution: fixed
Status: newclosed

This is basically finished, although technically some of the rules should be moved from dijit.css to tundra.css, but we'll worry about that when we do soria.

Note: See TracTickets for help on using tickets.