Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4121 closed defect (fixed)

dijit.layout.layoutChildren should work on a set of raw DOM nodes, not just widgets

Reported by: alex Owned by: alex
Priority: high Milestone: 1.0
Component: General Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

today, layoutChildren assumes some properties on the children instances which make it impossible to simply pass a property-bag of DOM nodes (say, a dojo.NodeList? instance)

Change History (2)

comment:1 Changed 12 years ago by alex

Resolution: fixed
Status: newclosed

(In [10160]) make layoutChildren() friendly for lists of DOM nodes (not just widgets). Also, make sure that capitalize() and size() aren't always re-defined should the interpreter be written poorly. Fixes #4121

comment:2 Changed 12 years ago by bill

(In [10180]) Rollback part of [10160]. The bug description (refs #4121) is inaccurate: layoutChildren() already works on plain dom nodes, as explained in the function description and shown by, for example, TabContainer?.

Widgets must never access properties on the srcNodeRef. That's the parser's job. If you really need to process a dojo.NodeList? like this then call list.map(function(node){ return { domNode: node, layoutAlign: node.getAttribute("layoutAlign");})

Note: See TracTickets for help on using tickets.