Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#4116 closed defect (fixed)

ComboBox: test/example querying against a URL like foo.php?query=ca

Reported by: bill Owned by: wolfram
Priority: high Milestone: 1.0
Component: Dijit - Form Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Add test file for ComboBox/FilteringSelect? with trivial dojo.data Store that gets data from a URL, like the old incrementalDataStore. Implement URL as PHP code (can copy format in tests/layout/getResponse.php).

Change History (7)

comment:1 Changed 12 years ago by haysmark

We already have ones that use URLs. Whether it is a static file or a PHP file doesn't matter because the return format is the same . . .

Here is the URL that the test in the nightly uses:

http://archive.dojotoolkit.org/nightly/checkout/dijit/tests/form/comboBoxData.json

It's a URL right? It returns the same thing a PHP file would return right? So I'm not sure what we are supposed to do to prove this ticket is fixed beyond that.

Also, if we do implement a PHP file, it will break offline testing, which is bad.

comment:2 Changed 12 years ago by bill

It's a URL right? It returns the same thing a PHP file would return right?

No, it's different. A PHP file takes a query and returns the items matching the query. Example:

foo.php?query=a

returns:

[ "alabama", "arizona", "arkansas"]

(or something similar)

That's how people will be using Combobox/FilteringSelect? in real life so it's important to test. As I wrote in the bug description, "like the old incrementalDataStore" from 0.4.

comment:3 Changed 12 years ago by bill

Summary: ComboBox: test/example using URLComboBox: test/example querying against a URL like foo.php?query=ca

comment:4 Changed 12 years ago by bill

See #4597 for store that accesses the server on query, and [10692] for a reference PHP implementation that it can be hooked up to.

comment:5 Changed 12 years ago by bill

Owner: set to wolfram

comment:6 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

Fixed by [10875]. Thanks Wolfram!

comment:7 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.