Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#4091 closed defect (fixed)

FilteringSelect: allows a value of "More Choices"

Reported by: ptbrunet Owned by: haysmark
Priority: high Milestone: 1.0
Component: Dijit - Form Version: 0.9
Keywords: Cc: brunet@…
Blocked By: Blocking:

Description

Using the inline test case tab down to the FilteringSelect, backspace through all the characters, use the list box to select More Choices, press enter to choose that selection and enter again to close the box. The value (and displayed value) is now "More Choices" which is an invalid value.

Attachments (1)

4091.patch (2.5 KB) - added by haysmark 12 years ago.
Fixes #4091. When you go to the next page of a ComboBoxMenu?, the ComboBox? selects the next option in the list. This prevents the user from accidentally entering More Choices.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 12 years ago by ptbrunet

A related issue - when More Choices is selected and activated by pressing enter, when the refreshed list appears I think the selector needs to be on one of the items, such as Previous Choices. Currently none of the items are selected in the new list. Having a selected item is probably going to be helpful for a screen reader.

comment:2 Changed 12 years ago by bill

Owner: set to haysmark

comment:3 Changed 12 years ago by bill

Summary: Filtering Select allows a value of "More Choices"FilteringSelect: allows a value of "More Choices"

comment:4 Changed 12 years ago by haysmark

There is a bigger question to answer here: do we want InlineEditBox? to accept input from validation widgets that flag the input as invalid?

comment:5 Changed 12 years ago by ptbrunet

Cc: brunet@… added; ptbrunet removed

comment:6 Changed 12 years ago by haysmark

There are still some issues with the screen reader, but it works as the ticket description says it should.

comment:7 Changed 12 years ago by haysmark

Status: newassigned

Changed 12 years ago by haysmark

Attachment: 4091.patch added

Fixes #4091. When you go to the next page of a ComboBoxMenu?, the ComboBox? selects the next option in the list. This prevents the user from accidentally entering More Choices.

comment:8 Changed 12 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

(In [10618]) Fixes #4091. Proxy commit for haysmark. Reviewed by becky. When you go to the next page of a ComboBoxMenu??, the ComboBox?? selects the next option in the list. This prevents the user from accidentally entering More Choices.

comment:9 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.