Pressing enter key on a tree node fires execute but also an exception

[davidb]

Looking at the nightlies, I think this was introduced in [9996].

Note that there is no exception when using the mouse to execute nodes.

[bill]

Jared, can you take a look? We are calling continentStore.getLabel(item) but it's complaining that item isn't an item, even though it is. Presumably because it's not from the most recent query against continentStore. (Note that there are two trees both pointing to continentStore.) Should we make two separate stores?

[Jared Jurkiewicz]

The problem stems from the single store access and two fetches both triggering a simultaneous load (since the xhrGet is async). What needs to happen is that the first fetch requets needs to be the only data loader and the subsequent fetch requests are queued up while the first is going on; then they are executed when the first finishes.

Working on a patch for this issue for the datastore...

[Jared Jurkiewicz]

Fixed ItemFileStore? and such. Working on the stores in dojox, like CsvStore?. Having issues on IE that I don't understand. Something strange is going on. Will hopefully have a fix for all stores tomorrow sometime. IE is such a pain.

[Jared Jurkiewicz]

(In [10054]) Updates to handle multiple fetches odduring at dat aload time. refs #4067

[Jared Jurkiewicz]

(In [10055]) Updates to handle multiple fetches odduring at data load time. refs #4067

[Jared Jurkiewicz]

Tested changes on:

Firefox 2.0.0.5 Firefox 1.5.0.12 IE 6 IE 7 Safari B3 Seamonkey 1.1.2

[Jared Jurkiewicz]

(In [10057]) Updates to XmlStore? to account for declare syntax change. refs #4067

[Jared Jurkiewicz]

(In [10059]) Added longer timeout to the paging test, since across webservers it can take a bit longer to run. refs #4067

[davidb]

Thanks for your work jaredj, unfortunately this bug is still presenting for me in the nightly build. ​http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/test_Tree.html (Tested using FF 2.0.0.6)

[davidb]

Note that this bug does not present when a node is executed via mouse.

[bill]

If it's only enter key then it's not a dojo.data problem. But I can't reproduce. Which browser? Which OS? Which tree? Any node in the tree?

[Jared Jurkiewicz]

Reassigning to bill, as the issue with dojo.data has been fixed. Any other exceptions would not be related to dojo.data

[Jared Jurkiewicz]

And double-checking what is being passed into the ItemFileReadStore? when enter is hit. Something funny is definitely going on with what is being passed to the store. Wondering if there is some static sharing going on between the two trees.

[Jared Jurkiewicz]

Yes, the tree is definitely passing something odd with the top tree when enter is hit/ See:

When mouse clicked: Item attr: [name] has value: [Africa] Item attr: [type] has value: [continent] Item attr: [children] has value: object Object],[object Object],[object Object? Item attr: [_RI] has value: [true] Item attr: [_S] has value: object Object? Item attr: [_0] has value: [0] execute message for [dijit._TreeNode, Africa]

When enter is pressed: Null or undefined item! item is: undefined [Exception... "'Error: dojo.data.ItemFileReadStore?: a function was passed an item argument that was not an item' when calling method: [nsIDOMEventListener::handleEvent]" nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)" location: "<unknown>" data: no]

So, it looks like the top tree is passing an undefined item on pressing enter, which of course will cause ItemFileReadStore? to throw an exception; not a valid item.

Looking a bit further to see where the Tree gets its items.

[Jared Jurkiewicz]

Problem is in onKeyPress:

}else{ handle non-printables (arrow keys)

if(this._keyTopicMap[e.keyCode]){

this._publish(this._keyTopicMap[e.keyCode], { node: treeNode } ); dojo.stopEvent(e);

}

}

For execute topics, which will cause a store query, it's not passing the item.

Simple fix should be something like:

}else{ handle non-printables (arrow keys)

if(this._keyTopicMap[e.keyCode]){

this._publish(this._keyTopicMap[e.keyCode], { node: treeNode, item: treeNode.item } ); dojo.stopEvent(e);

}

}

[Jared Jurkiewicz]

(In [10197]) Fixing a minor issue in tree with how it publishes the item. fixes #4067