Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4063 closed defect (fixed)

[CLA-patch] Fixes to dojox.presentation & dojo.timing port

Reported by: guest Owned by: dante
Priority: high Milestone:
Component: Dojox Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

These are some fixes to dojox.presentation and some refactoring,

  • if showNav was false, the presentation would break
  • dojo.require('dojox.presentation') not working
  • the titlePane would be moveable under Firefox 2.0.0.6

If could not find the DOM node, the id would get lost in this.buildRendering();

Patch also include a port of dojo.timing to dojox

Attachments (1)

presentation.patch (18.8 KB) - added by guest 12 years ago.

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by guest

Attachment: presentation.patch added

comment:1 Changed 12 years ago by bill

Component: GeneralDojox
Owner: changed from anonymous to dante

Who wrote this patch? You said you have a CLA but you posted the patch anonymously.

comment:2 Changed 12 years ago by guest

I always put -- Your email or username: jbondc@…

I thought it was resetting it as guest for privacy reasons. CLA: Jonathan Bond-Caron

comment:3 Changed 12 years ago by dante

Status: newassigned

is there a list somewhere of CLA's signed? can anyone verify this CLA, i'd like to squeeze this in before 0.9 (although it's dojox ... i assume dojox is going out with 0.9 dijit/dojo this time, and will roll it's own release mechanism afterward?)

also, any thoughts on dojox.timing port? ttrenka? anyone?

comment:4 Changed 12 years ago by dante

okay in [10040] alex thanks jonathan bond-caron for the patch, so i am assuming the cla is valid.

comment:5 Changed 12 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [10041]) cleanups and fixes to dojox.presentation courtesy Jonathan Bond-Caron [cla]. fixes #4063 (thought there is a dijit one-line patch that did not get merged, and affects presentation get/setHash) also replaces templateString w/ templatePath and make header not have padding extents.

and does not merge dojox.timing code from the patch. sent email requesting a REAMDE + testcase for dojox.timing, and would be happy to proxy commit should Mr Bond-Caron care to take 'ownership' of dojox.timing (pending comments from ttrenka)

comment:6 Changed 12 years ago by bill

FYI, contributors are listed at http://dojo.jot.com/ContributorListing

comment:7 Changed 12 years ago by dante

(In [10074]) initial checkin of dojox.timing project, a port of dojo.lang.Timer and Streamer from 0.4 - courtesy jonathan bond-caron [cla] refs #4063 - needs README and test(s) ...

Note: See TracTickets for help on using tickets.