#4063 closed defect (fixed)
[CLA-patch] Fixes to dojox.presentation & dojo.timing port
Reported by: | guest | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | |
Component: | Dojox | Version: | 0.9 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
These are some fixes to dojox.presentation and some refactoring,
- if showNav was false, the presentation would break
- dojo.require('dojox.presentation') not working
- the titlePane would be moveable under Firefox 2.0.0.6
If could not find the DOM node, the id would get lost in this.buildRendering();
Patch also include a port of dojo.timing to dojox
Attachments (1)
Change History (8)
Changed 13 years ago by
Attachment: | presentation.patch added |
---|
comment:1 Changed 13 years ago by
Component: | General → Dojox |
---|---|
Owner: | changed from anonymous to dante |
comment:2 Changed 13 years ago by
I always put -- Your email or username: [email protected]…
I thought it was resetting it as guest for privacy reasons. CLA: Jonathan Bond-Caron
comment:3 Changed 13 years ago by
Status: | new → assigned |
---|
is there a list somewhere of CLA's signed? can anyone verify this CLA, i'd like to squeeze this in before 0.9 (although it's dojox ... i assume dojox is going out with 0.9 dijit/dojo this time, and will roll it's own release mechanism afterward?)
also, any thoughts on dojox.timing port? ttrenka? anyone?
comment:4 Changed 13 years ago by
okay in [10040] alex thanks jonathan bond-caron for the patch, so i am assuming the cla is valid.
comment:5 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
(In [10041]) cleanups and fixes to dojox.presentation courtesy Jonathan Bond-Caron [cla]. fixes #4063 (thought there is a dijit one-line patch that did not get merged, and affects presentation get/setHash) also replaces templateString w/ templatePath and make header not have padding extents.
and does not merge dojox.timing code from the patch. sent email requesting a REAMDE + testcase for dojox.timing, and would be happy to proxy commit should Mr Bond-Caron care to take 'ownership' of dojox.timing (pending comments from ttrenka)
comment:6 Changed 13 years ago by
FYI, contributors are listed at http://dojo.jot.com/ContributorListing
Who wrote this patch? You said you have a CLA but you posted the patch anonymously.