Opened 15 years ago
Closed 15 years ago
#406 closed defect (fixed)
dnd won't start dragging in at least ie6
Reported by: | spackest | Owned by: | anonymous |
---|---|---|---|
Priority: | high | Milestone: | |
Component: | General | Version: | 0.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
In my experience, for all the tests in http://archive.dojotoolkit.org/nightly/tests/dnd/ dragging won't start in ie6. I tracked down the ie problem to part of the revision 2994 commit, src/dnd/HtmlDragManager.js for which annotate has 2994 david // only begin on left click 2994 david if(dojo.render.html.ie) { 2994 david if(e.button != 0) { return; } 2994 david } else if(e.which != 1) { 2994 david return; 2994 david }
I think the e.button number is just wrong. In my testing, the left button is 1, right button is 2. Changing the 0 to a 1 as per the patch below, will at least let the dragging start
Index: src/dnd/HtmlDragManager.js =================================================================== --- src/dnd/HtmlDragManager.js (revision 3013) +++ src/dnd/HtmlDragManager.js (working copy) @@ -131,7 +131,7 @@ // only begin on left click if(dojo.render.html.ie) { - if(e.button != 0) { return; } + if(e.button != 1) { return; } } else if(e.which != 1) { return; }
Note: See
TracTickets for help on using
tickets.
Fixed in #3020.