Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#405 closed defect (duplicate)

dnd won't start dragging in at least ie6

Reported by: spackest Owned by: anonymous
Priority: high Milestone:
Component: General Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

In my experience, for all the tests in

http://archive.dojotoolkit.org/nightly/tests/dnd/

dragging won't start in ie6.

I tracked down the ie problem to part of the revision 2994 commit, src/dnd/HtmlDragManager.js for which annotate has

2994 david only begin on left click 2994 david if(dojo.render.html.ie) { 2994 david if(e.button != 0) { return; } 2994 david } else if(e.which != 1) { 2994 david return; 2994 david }

I think the e.button number is just wrong. In my testing, the left button is 1, right button is 2. Changing the 0 to a 1 as per the patch below, will at least let the dragging start

Index: src/dnd/HtmlDragManager.js =================================================================== --- src/dnd/HtmlDragManager.js (revision 3013) +++ src/dnd/HtmlDragManager.js (working copy) @@ -131,7 +131,7 @@

only begin on left click if(dojo.render.html.ie) {

  • if(e.button != 0) { return; }

+ if(e.button != 1) { return; }

} else if(e.which != 1) {

return;

}

Change History (3)

comment:1 Changed 14 years ago by bill

Resolution: duplicate
Status: newclosed

Same as #406

comment:2 Changed 14 years ago by alex

Milestone: 0.3release
Version: 0.30.2

"version" is for what version a bug was discovered in, whereas "milestone" is for the milestone in which it was fixed. At the very least, assigning things to the right milestone allows us to accurately track what was fixed/closed when.

comment:3 Changed 12 years ago by (none)

Milestone: 0.3release

Milestone 0.3release deleted

Note: See TracTickets for help on using tickets.