Opened 12 years ago

Closed 9 years ago

#4017 closed defect (fixed)

Accordion: bottom pane bleeds past AccordionContainer border

Reported by: bill Owned by: bill
Priority: high Milestone: 1.6
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Adam Peller)

On IE6, "accordion pane with complex widgets" example in test_Accordion.html, click pane 3. The pane contents are visible below the AccordionContainer? bottom border as they are sliding in.

Should fix this or desupport complex widgets in accordion for 0.9.

Change History (9)

comment:1 Changed 12 years ago by Adam Peller

(In [10003]) De-support SplitContainer? inside AccordionContainer?. Refs #4016, #4017

comment:2 Changed 12 years ago by Adam Peller

Milestone: 0.91.0

This behaves strangely in 1.0, too. De-supported for now.

comment:3 Changed 12 years ago by Adam Peller

oops. Meant this behaves strangely in Firefox, too.

comment:4 Changed 12 years ago by bill

Summary: Accordion: bottom pane bleeds past AccordionContainer border (IE6)Accordion: bottom pane bleeds past AccordionContainer border

(just changing title to reflect that it's not an IE specific problem)

comment:5 Changed 12 years ago by Adam Peller

Milestone: 1.01.1

comment:6 Changed 11 years ago by Adam Peller

Milestone: 1.11.2

still unsupported in 1.1

comment:7 Changed 11 years ago by Adam Peller

Description: modified (diff)
Milestone: 1.2future

comment:8 Changed 9 years ago by bill

Milestone: future1.6
Owner: changed from Adam Peller to bill
Status: newassigned

comment:9 Changed 9 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [22677]) Fix AccordionContainer rendering problems, by properly accounting for margin/border/padding and by dealing w/the fact that during the animation, on claro, need to account for two blue borders wrapping around the two "active" children. See comments in code for more details.

This fixes the problem where the animation doesn't work well when there's lots of padding on the child ContentPane, and also the problem where the blue trim underneath a child ContentPane (claro only) would disappear during the animation.

Also, added correct handling for race condition when another pane is selected or the accordion is destroyed while an animation is in progress.

IE6 and IE7 have overflow problems with this new design (the overflow: hidden isn't taking effect), but rather than fix the problem I just disabled the animation for those browsers.

Fixes #4017, #7389, #9141 !strict.

Also removed some workaround code for #11415, and from [21426] (#10527), that seems to no longer be needed.

Note: See TracTickets for help on using tickets.