Changes between Initial Version and Version 5 of Ticket #3990


Ignore:
Timestamp:
Aug 9, 2007, 8:21:05 AM (13 years ago)
Author:
alex
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3990

    • Property Status changed from new to assigned
    • Property Summary changed from custom_rhino.diff - Invalid parser to [patch]custom_rhino.diff - Invalid parser
    • Property Milestone changed from to 0.9
    • Property Owner changed from James Burke to alex
    • Property Severity changed from blocker to critical

  • Ticket #3990 – Description

    initial v5  
    11When trying to build the following code:
    22
     3{{{
    34                cb = function(){
    45                    this.hideAction();
    … …  
    78                    }
    89                }.createDelegate(this);
     10}}}
    911
    1012The dojo optimizer (Shrinksafe) will replace the last line with:
     13{{{
     14};.createDelegate(this);
     15}}}
    1116
    12 };.createDelegate(this);
    13 
     17{{{
    1418                cb = function(){
    1519                    this.hideAction();
    … …  
    1822                    }
    1923                };.createDelegate(this);
     24}}}
    2025
    2126This ends up being invalid javascript. After going through rhino, here's the needed fix:
    2227
     28{{{
    2329>                      case FUNCTION_END:
    2430>                         if (
    … …  
    3036>                             (getNext(encodedSource, length, i+1) != Token.DOT) &&
    3137>                             (getNext(encodedSource, length, i+1) != Token.COLON) &&
    32 
     38}}}
    3339
    3440So adding the line:
     41{{{
    3542>                             (getNext(encodedSource, length, i+1) != Token.DOT) &&
     43}}}