[patch]custom_rhino.diff - Invalid parser

[guest]

When trying to build the following code:

                cb = function(){
                    this.hideAction();
                    if(c){
                        c();
                    }
                }.createDelegate(this);

The dojo optimizer (Shrinksafe) will replace the last line with:

};.createDelegate(this);

                cb = function(){
                    this.hideAction();
                    if(c){
                        c();
                    }
                };.createDelegate(this);

This ends up being invalid javascript. After going through rhino, here's the needed fix:

>                      case FUNCTION_END:
>                         if (
>                             (getNext(encodedSource, length, i+1) != Token.SEMI) &&
>                             (getNext(encodedSource, length, i+1) != Token.LP) &&
>                             (getNext(encodedSource, length, i+1) != Token.RP) &&
>                             (getNext(encodedSource, length, i+1) != Token.RC) &&
>                             (getNext(encodedSource, length, i+1) != Token.COMMA) &&
>                             (getNext(encodedSource, length, i+1) != Token.DOT) &&
>                             (getNext(encodedSource, length, i+1) != Token.COLON) &&

So adding the line:

>                             (getNext(encodedSource, length, i+1) != Token.DOT) &&

[guest]

Btw my CLA is on file, Jonathan Bond-Caron

[James Burke]

Adding a milestone, but Alex may reprioritize.

[alex]

(In [10040]) ensuring that we don't step on the intrinsic return value of functions. Fixes #3990. Thanks to Jonathan Bond-Caron for the bug report and patch.