Opened 15 years ago
Closed 15 years ago
#3990 closed defect (fixed)
[patch]custom_rhino.diff - Invalid parser
Reported by: | guest | Owned by: | alex |
---|---|---|---|
Priority: | blocker | Milestone: | 0.9 |
Component: | BuildTools | Version: | 0.9 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
When trying to build the following code:
cb = function(){ this.hideAction(); if(c){ c(); } }.createDelegate(this);
The dojo optimizer (Shrinksafe) will replace the last line with:
};.createDelegate(this);
cb = function(){ this.hideAction(); if(c){ c(); } };.createDelegate(this);
This ends up being invalid javascript. After going through rhino, here's the needed fix:
> case FUNCTION_END: > if ( > (getNext(encodedSource, length, i+1) != Token.SEMI) && > (getNext(encodedSource, length, i+1) != Token.LP) && > (getNext(encodedSource, length, i+1) != Token.RP) && > (getNext(encodedSource, length, i+1) != Token.RC) && > (getNext(encodedSource, length, i+1) != Token.COMMA) && > (getNext(encodedSource, length, i+1) != Token.DOT) && > (getNext(encodedSource, length, i+1) != Token.COLON) &&
So adding the line:
> (getNext(encodedSource, length, i+1) != Token.DOT) &&
Change History (6)
comment:1 Changed 15 years ago by
Owner: | changed from James Burke to alex |
---|---|
severity: | blocker → critical |
Summary: | custom_rhino.diff - Invalid parser → [patch]custom_rhino.diff - Invalid parser |
comment:2 Changed 15 years ago by
comment:4 Changed 15 years ago by
Status: | new → assigned |
---|
comment:5 Changed 15 years ago by
Description: | modified (diff) |
---|
comment:6 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Btw my CLA is on file, Jonathan Bond-Caron