Slider: with no discreteValues fails to send events via buttons

[guest]

HOW TO REPRODUCE:

Go to <​http://82.230.65.68:31416/~fred/dojo/fred_samples/bug_002.html>
Click +

EXPECTED RESULT:

Value change to something like 0.0009852216748768472

RESULT:

Event is not fired, value not updated

[guest]

Test case, as linked in the report

[guest]

This is on Mac OS X, Firefox, with dojo 0.9 serial #9050

[Douglas Hays]

(In [10021]) Fixes #3983. Special case discreteValues <= 1

[guest]

I must be very stupid, but, with revision [10028], I still have the reported behavior.

Click on link bug_002.html Click on + button several time Value stays zero (If you click anywhere in the window, it is updated, but it is too late)

I also think the title of the issue is wrong: it should be "Slider with no intermediateChanges" don't send events via buttons.

[Douglas Hays]

Clicking the buttons is an intermediate change - since intermediateChanges=false, no onChange event fires. Clicking the draggable handle and using the arrow keys are also intermediate changes. When the widget loses focus, then the onChange event fires for the last intermediate change. Dragging the handle is also an intermediate change, but the mouseup event after dragging causes the onChange event to fire to allow webkit users who can't focus on div's to use the slider.

[guest]

Omg, I did not realise that this was the expected behavior. Time to argue against that on the forums, then.

Thanks for the update.

[bill]

OK, we talked about this on IRC for a while. Decided it was too confusing to not fire an onChange event on arrow key or arrow button (imagine that a vertical slider is used to control the position in a table widget and the user hits the + button to go down one page). So let's change this to fire on arrow keyup or arrow button.

[Douglas Hays]

The suggested behavior is different than the Spinner widget which is only slightly different the slider. Also, we might want slider to behave well with InlineEditBox? - and an immediate value change will close the editing sesson.

[bill]

OK, let's think about this more after 0.9 is released.

[Douglas Hays]

(In [10730]) Fixes #3983. Arrow keys and button clicks in slider now cause onChange to fire all the time, ignoring the intermediateChanges flag.