Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#3970 closed defect (fixed)

Add Rhino "strict" mode to pre-commit hook

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone:
Component: Operations Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Adam Peller)

http://developer.mozilla.org/en/docs/New_in_Rhino_1.6R6

catches trailing commas, as well as some jslint-like style checks

will discuss this with the list first, but I think it would be a very good thing to have.

Change History (10)

comment:1 Changed 12 years ago by Adam Peller

Milestone: 1.1

comment:2 Changed 12 years ago by Adam Peller

Component: GeneralOps
Milestone: 1.1

comment:3 Changed 12 years ago by Adam Peller

(In [11868]) test strict mode. Refs #3970

comment:4 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [11876]) undo strict mode tests. Fixes #3970

comment:5 Changed 12 years ago by Adam Peller

so let's see how this goes. You can override the strict mode check by putting "!strict" in your checkin comment.

comment:6 Changed 12 years ago by Adam Peller

(In [11879]) Extra comma. Refs #3970

comment:7 Changed 12 years ago by Adam Peller

(In [11880]) Remove extra comma. Refs #3970

comment:8 Changed 12 years ago by Adam Peller

(In [11881]) Extra comma. Refs #3970

comment:9 Changed 12 years ago by Adam Peller

(In [11882]) Remove extra comma. Refs #3970

comment:10 Changed 11 years ago by Adam Peller

Description: modified (diff)

So upon a closer reading of the release notes, Rhino only catches trailing commas on Object initializers; we want to catch them on Object (and Array) literals.

Filed a request for enhancement here: https://bugzilla.mozilla.org/show_bug.cgi?id=449253

Note: See TracTickets for help on using tickets.