Opened 13 years ago

Closed 12 years ago

#395 closed enhancement (wontfix)

[patch][cla] Dojo Compressor should support JScript conditional compilation

Reported by: bob@… Owned by: jkuhnert
Priority: high Milestone: 1.0
Component: BuildTools Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

Currently, Dojo's Compressor strips JScript conditional compilation expressions, but it would be very useful if it didn't.

Documentation for the conditional compilation feature is here (for the relevant version of JScript): http://msdn.microsoft.com/library/en-us/script56/html/a843de4e-3aae-43cd-ad64-477dd00814a2.asp

and the newer documentation for JScript.NET is here: http://msdn.microsoft.com/library/en-us/jscript7/html/jsConditionalCompilation.asp

Attachments (1)

compressJs (445 bytes) - added by guest 13 years ago.
bash script to work around Ticket #395

Download all attachments as: .zip

Change History (13)

comment:1 Changed 13 years ago by alex

Milestone: 0.3release
Owner: changed from anonymous to alex
Status: newassigned

The changes to fix this will require adding comment data back into the parse stream. Currently, they are discarded and don't appear in the token stream in the interest of saving space.

comment:2 Changed 13 years ago by alex

Milestone: 0.3release0.3.1

comment:3 Changed 13 years ago by alex

Milestone: 0.3.10.4

punt!

Changed 13 years ago by guest

Attachment: compressJs added

bash script to work around Ticket #395

comment:4 Changed 13 years ago by guest

I have written a small bash script that transforms the conditional compilation directives into expressions that are not stripped, compresses the script and retransforms the compilation directives into their old form. it can be found under (see also http://fforw.de/post/Dojo_Javascript_Compression_and_IE_conditional_compilation/ )

comment:5 Changed 13 years ago by jkuhnert

Owner: changed from alex to jkuhnert
Status: assignednew

comment:6 Changed 13 years ago by dylan

Summary: Dojo Compressor should support JScript conditional compilation[patch][cla] Dojo Compressor should support JScript conditional compilation

comment:7 Changed 13 years ago by dylan

Milestone: 0.40.5

comment:8 Changed 13 years ago by jkuhnert

Milestone: 0.50.4.1
Status: newassigned

comment:9 Changed 13 years ago by alex

Jesse, why did you move this back? Do you think you'll hit it for 0.4.1?

comment:10 Changed 13 years ago by jkuhnert

Milestone: 0.4.10.6

Oops! I did actually investigate this one and finally re-remembered that rhino doesn't parse out comments at all. This one is going to be a real pain.

comment:11 Changed 12 years ago by Adam Peller

bump

comment:12 Changed 12 years ago by Adam Peller

Resolution: wontfix
Status: assignedclosed

please reopen if there is any plan to fix this

Note: See TracTickets for help on using tickets.