Opened 16 years ago
Closed 15 years ago
#395 closed enhancement (wontfix)
[patch][cla] Dojo Compressor should support JScript conditional compilation
Reported by: | Owned by: | jkuhnert | |
---|---|---|---|
Priority: | high | Milestone: | 1.0 |
Component: | BuildTools | Version: | 0.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Currently, Dojo's Compressor strips JScript conditional compilation expressions, but it would be very useful if it didn't.
Documentation for the conditional compilation feature is here (for the relevant version of JScript): http://msdn.microsoft.com/library/en-us/script56/html/a843de4e-3aae-43cd-ad64-477dd00814a2.asp
and the newer documentation for JScript.NET is here: http://msdn.microsoft.com/library/en-us/jscript7/html/jsConditionalCompilation.asp
Attachments (1)
Change History (13)
comment:1 Changed 16 years ago by
Milestone: | → 0.3release |
---|---|
Owner: | changed from anonymous to alex |
Status: | new → assigned |
comment:2 Changed 16 years ago by
Milestone: | 0.3release → 0.3.1 |
---|
comment:4 Changed 16 years ago by
I have written a small bash script that transforms the conditional compilation directives into expressions that are not stripped, compresses the script and retransforms the compilation directives into their old form. it can be found under (see also http://fforw.de/post/Dojo_Javascript_Compression_and_IE_conditional_compilation/ )
comment:5 Changed 16 years ago by
Owner: | changed from alex to jkuhnert |
---|---|
Status: | assigned → new |
comment:6 Changed 16 years ago by
Summary: | Dojo Compressor should support JScript conditional compilation → [patch][cla] Dojo Compressor should support JScript conditional compilation |
---|
comment:7 Changed 16 years ago by
Milestone: | 0.4 → 0.5 |
---|
comment:8 Changed 16 years ago by
Milestone: | 0.5 → 0.4.1 |
---|---|
Status: | new → assigned |
comment:9 Changed 16 years ago by
Jesse, why did you move this back? Do you think you'll hit it for 0.4.1?
comment:10 Changed 16 years ago by
Milestone: | 0.4.1 → 0.6 |
---|
Oops! I did actually investigate this one and finally re-remembered that rhino doesn't parse out comments at all. This one is going to be a real pain.
comment:12 Changed 15 years ago by
Resolution: | → wontfix |
---|---|
Status: | assigned → closed |
please reopen if there is any plan to fix this
The changes to fix this will require adding comment data back into the parse stream. Currently, they are discarded and don't appear in the token stream in the interest of saving space.