Opened 12 years ago

Closed 12 years ago

#3944 closed defect (fixed)

Adding things to Object.prototype breaks xdomain loading

Reported by: James Burke Owned by: James Burke
Priority: high Milestone: 1.0
Component: Loader Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

If some other code adds something to Object.prototype, xd loading breaks since it is using an object as a hashmap to find modules that are still being loaded.

While other things in the toolkit may break if someone is bad and modifies Object.prototype, I would like xdomain loading to still work.

Change History (1)

comment:1 Changed 12 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [10838]) Fixes #3944. Prevent bad code that adds things to Object.prototype to cause errors in xdomain loading. Not bullet-proof, if an Object.prototype property is added that is a boolean true, xd loading will fail, but hey, don't do that to Object.prototype.

Note: See TracTickets for help on using tickets.