Opened 12 years ago
Closed 12 years ago
#3943 closed defect (fixed)
Scrub dojo.i18n.getLocalization calls to allow safe layered xdomain loading
| Reported by: | James Burke | Owned by: | James Burke |
|---|---|---|---|
| Priority: | high | Milestone: | 0.9 |
| Component: | Loader | Version: | 0.9 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
If a module gets put into a layer, and that layer is loaded on page load via a normal script tag defined in the HTML, the dojo.i18n.getLocalization() calls could fail in an xdomain loading case.
If dojo.i18n.getLocalization is called while the module/object is being defined during the evaluation of the script, the i18n bundle may not have loaded yet.
Need to scrub dojo/dijit/dojox code to make sure the dojo.i18n.getLocalization calls happen in either a dojo.addOnLoad() call or as part of a widget lifecycle event (like postCreate). Probably need to inform dojo-contributors of this requirement too, to avoid issues down the road.
This should be fixed for 0.9 final.
Note: See
TracTickets for help on using
tickets.
Did a quick check for getLocalization calls. They all look good.